fixing tests

Author: ricksmith130

src/components/form-elements/select/__tests__/Select.test.tsx

@@ -48,7 +48,7 @@ describe('Select', () => {
     const selectEl = container.querySelector('select')!;
     fireEvent.click(selectEl);
 
-    expect(useRefSpy).toBeCalledWith(null);
-    expect(mock).toBeCalledTimes(1);
+    expect(useRefSpy).toHaveBeenCalledWith(null);
+    expect(mock).toHaveBeenCalledTimes(1);
   });
 });

src/components/form-elements/text-input/__tests__/TextInput.test.tsx

@@ -28,8 +28,8 @@ describe('TextInput', () => {
     const textInputEl = container.querySelector('input')!;
     fireEvent.click(textInputEl);
 
-    expect(useRefSpy).toBeCalledWith(null);
-    expect(mock).toBeCalledTimes(1);
+    expect(useRefSpy).toHaveBeenCalledWith(null);
+    expect(mock).toHaveBeenCalledTimes(1);
   });
 
   it.each<InputWidth | undefined>([undefined, '5', '10'])(

src/components/navigation/back-link/__tests__/__snapshots__/BackLink.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`BackLink matches snapshot: BackLink 1`] = `
 <div>

src/components/navigation/breadcrumb/Breadcrumb.tsx

@@ -48,9 +48,9 @@ const Breadcrumb: FC<BreadcrumbProps> & { Item: typeof Item; Back: typeof Back }
   const { ItemChildren, OtherChildren } = React.Children.toArray(children).reduce<SplitChildren>(
     (prev, child) => {
       if (childIsOfComponentType(child, Item)) {
-        prev.ItemChildren.push(child);
+        prev.ItemChildren.push(child as ReactNode);
       } else {
-        prev.OtherChildren.push(child);
+        prev.OtherChildren.push(child as ReactNode);
       }
       return prev;
     },

src/components/navigation/breadcrumb/__tests__/Breadcrumb.test.tsx

@@ -1,4 +1,4 @@
-import React, { ElementType } from 'react';
+import React from 'react';
 import { render } from '@testing-library/react';
 import Breadcrumb from '../';
 
@@ -87,7 +87,7 @@ describe('Breadcrumb', () => {
       },
     );
 
-    it.each<ElementType | undefined>([undefined, 'button'])(
+    it.each<string | undefined>([undefined, 'button'])(
       'Renders with asElement when specified as %s',
       (asElement) => {
         const { container } = render(
@@ -100,7 +100,7 @@ describe('Breadcrumb', () => {
 
         const component = container.querySelector('.nhsuk-breadcrumb__backlink');
 
-        expect(component?.nodeName).toBe(asElement?.toString()?.toUpperCase() ?? 'A');
+        expect(component?.nodeName).toBe(asElement?.toUpperCase() ?? 'A');
       },
     );
   });

src/components/navigation/card/components/CardLink.tsx

@@ -2,7 +2,7 @@ import React, { FC } from 'react';
 import classNames from 'classnames';
 import { AsElementLink } from '@util/types/LinkTypes';
 
-const CardLink: FC<AsElementLink<HTMLAnchorElement>> = ({
+const CardLink: FC<AsElementLink<'a'>> = ({
   className,
   asElement: Component = 'a',
   ...rest