Skip to content

Commit dd7fd1d

Browse files
authored
Merge pull request #33 from NHSDigital/feature/tjc-fixSmallAlignmentIssues
Small alignments with nhsuk-frontend
2 parents fbd7137 + 334dfd7 commit dd7fd1d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/components/care-card/CareCard.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ const CareCardHeading: React.FC<CareCardHeadingProps> = ({
3636
children,
3737
visuallyHiddenText,
3838
headingLevel,
39+
role,
3940
...rest
4041
}) => {
4142
const cardType = useContext(CareCardContext);
@@ -46,7 +47,7 @@ const CareCardHeading: React.FC<CareCardHeadingProps> = ({
4647
headingLevel={headingLevel}
4748
{...rest}
4849
>
49-
<span role="heading">
50+
<span role={role}>
5051
{visuallyHiddenText !== false ? (
5152
<span className="nhsuk-u-visually-hidden">
5253
{visuallyHiddenText || genHiddenText(cardType)}
@@ -60,6 +61,10 @@ const CareCardHeading: React.FC<CareCardHeadingProps> = ({
6061
);
6162
};
6263

64+
CareCardHeading.defaultProps = {
65+
role: 'text',
66+
};
67+
6368
interface CareCard extends React.FC<CareCardProps> {
6469
Content: React.FC<HTMLProps<HTMLDivElement>>;
6570
Heading: React.FC<CareCardHeadingProps>;

src/components/header/components/Nav.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ const Nav: React.FC<HTMLProps<HTMLDivElement>> = ({
2525
<Container>
2626
<p className="nhsuk-header__navigation-title">
2727
<span>Menu</span>
28-
<button className="nhsuk-header__navigation-close" onClick={toggleMenu}>
28+
<button className="nhsuk-header__navigation-close" type="button" onClick={toggleMenu}>
2929
<CloseIcon />
30+
<span className="nhsuk-u-visually-hidden">Close menu</span>
3031
</button>
3132
</p>
3233
<ul className="nhsuk-header__navigation-list">{children}</ul>

0 commit comments

Comments
 (0)