Skip to content

Commit e16951a

Browse files
committed
updated imports for HTMLProps and FC
1 parent 0f9d61f commit e16951a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+293
-273
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
"license": "MIT",
7575
"packageManager": "[email protected]",
7676
"dependencies": {
77+
"chalk": "^5.6.2",
7778
"classnames": "^2.5.1",
7879
"i": "^0.3.7",
7980
"lodash": "^4.17.21",

rollup.config.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import tsPaths from 'rollup-plugin-tsconfig-paths';
88
import preserveDirectives from 'rollup-plugin-preserve-directives';
99
import postcss from 'rollup-plugin-postcss';
1010

11-
import tsBuildConfig from './bundle-base.tsconfig.json' assert { type: 'json' };
12-
import packageJson from './package.json' assert { type: 'json' };
11+
import tsBuildConfig from './bundle-base.tsconfig.json' with { type: 'json' };
12+
import packageJson from './package.json' with { type: 'json' };
1313

1414
// suppresses warnings printed to console as part of bundling components with directives present.
1515
const onWarnSuppression = {

src/components/content-presentation/details/Details.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import React from 'react';
2+
import { HTMLProps } from 'react'
23
import classNames from 'classnames';
34

4-
interface DetailsProps extends React.HTMLProps<HTMLDetailsElement> {
5+
interface DetailsProps extends HTMLProps<HTMLDetailsElement> {
56
expander?: boolean;
67
}
78

89
interface Details extends React.FC<DetailsProps> {
9-
Summary: React.FC<React.HTMLProps<HTMLDivElement>>;
10-
Text: React.FC<React.HTMLProps<HTMLDivElement>>;
11-
ExpanderGroup: React.FC<React.HTMLProps<HTMLDivElement>>;
10+
Summary: React.FC<HTMLProps<HTMLDivElement>>;
11+
Text: React.FC<HTMLProps<HTMLDivElement>>;
12+
ExpanderGroup: React.FC<HTMLProps<HTMLDivElement>>;
1213
}
1314

1415
// TODO: Check if standard NHS.UK polyfill "details.polyfill.js" is required
@@ -19,17 +20,17 @@ const Details: Details = ({ className, expander, ...rest }: any) => (
1920
/>
2021
);
2122

22-
const DetailsSummary: React.FC<React.HTMLProps<HTMLDivElement>> = ({ className, children, ...rest }) => (
23+
const DetailsSummary: React.FC<HTMLProps<HTMLDivElement>> = ({ className, children, ...rest }) => (
2324
<summary className={classNames('nhsuk-details__summary', className)} {...rest}>
2425
<span className="nhsuk-details__summary-text">{children}</span>
2526
</summary>
2627
);
2728

28-
const DetailsText: React.FC<React.HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
29+
const DetailsText: React.FC<HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
2930
<div className={classNames('nhsuk-details__text', className)} {...rest} />
3031
);
3132

32-
const ExpanderGroup: React.FC<React.HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
33+
const ExpanderGroup: React.FC<HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
3334
<div className={classNames('nhsuk-expander-group', className)} {...rest} />
3435
);
3536

src/components/content-presentation/do-and-dont-list/DoAndDontList.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
'use client';
2-
import React, { createContext, useContext } from 'react';
2+
import React, { createContext, useContext, HTMLProps } from 'react';
33
import classNames from 'classnames';
44
import { Tick, Cross } from '@components/content-presentation/icons';
55
import HeadingLevel, { HeadingLevelType } from '@components/utils/HeadingLevel';
66

77
type ListType = 'do' | 'dont';
88

9-
interface DoAndDontListProps extends React.HTMLProps<HTMLDivElement> {
9+
interface DoAndDontListProps extends HTMLProps<HTMLDivElement> {
1010
listType: ListType;
1111
heading?: string;
1212
headingLevel?: HeadingLevelType;
@@ -44,7 +44,7 @@ const DoAndDontList: DoAndDontList = ({
4444
);
4545
};
4646

47-
interface DoAndDontItemProps extends React.HTMLProps<HTMLLIElement> {
47+
interface DoAndDontItemProps extends HTMLProps<HTMLLIElement> {
4848
listItemType?: ListType;
4949
prefixText?: React.ReactNode;
5050
}

src/components/content-presentation/hero/Hero.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import React from 'react';
1+
import React, { HTMLProps } from 'react';
22
import classNames from 'classnames';
33
import { Container, Row, Col } from '../../layout';
44
import HeadingLevel, { HeadingLevelType } from '@components/utils/HeadingLevel';
55

6-
interface HeroContentProps extends React.HTMLProps<HTMLDivElement> {
6+
interface HeroContentProps extends HTMLProps<HTMLDivElement> {
77
hasImage: boolean;
88
}
99

@@ -29,7 +29,7 @@ const HeroContent: React.FC<HeroContentProps> = ({ children, hasImage }) => {
2929
);
3030
};
3131

32-
interface HeroHeadingProps extends React.HTMLProps<HTMLHeadingElement> {
32+
interface HeroHeadingProps extends HTMLProps<HTMLHeadingElement> {
3333
headingLevel?: HeadingLevelType;
3434
}
3535

@@ -41,17 +41,17 @@ const HeroHeading: React.FC<HeroHeadingProps> = ({ className, headingLevel = 'h1
4141
/>
4242
);
4343

44-
const HeroText: React.FC<React.HTMLProps<HTMLParagraphElement>> = ({ className, ...rest }) => (
44+
const HeroText: React.FC<HTMLProps<HTMLParagraphElement>> = ({ className, ...rest }) => (
4545
<p className={classNames('nhsuk-body-l nhsuk-u-margin-bottom-0', className)} {...rest} />
4646
);
4747

48-
interface HeroProps extends React.HTMLProps<HTMLDivElement> {
48+
interface HeroProps extends HTMLProps<HTMLDivElement> {
4949
imageSrc?: string;
5050
}
5151

5252
interface Hero extends React.FC<HeroProps> {
5353
Heading: React.FC<HeroHeadingProps>;
54-
Text: React.FC<React.HTMLProps<HTMLParagraphElement>>;
54+
Text: React.FC<HTMLProps<HTMLParagraphElement>>;
5555
}
5656

5757
const Hero: Hero = ({ className, children, imageSrc, ...rest }) => (

src/components/content-presentation/icons/BaseIcon.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import React from 'react';
1+
import React, { HTMLProps, FC } from 'react';
22
import classNames from 'classnames';
33

4-
export interface BaseIconSVGProps extends React.HTMLProps<SVGSVGElement> {
4+
export interface BaseIconSVGProps extends HTMLProps<SVGSVGElement> {
55
iconType?: string;
66
crossOrigin?: '' | 'anonymous' | 'use-credentials';
77
}
88

9-
export const BaseIconSVG: React.FC<BaseIconSVGProps> = ({
9+
export const BaseIconSVG: FC<BaseIconSVGProps> = ({
1010
className,
1111
children,
1212
height = 34,

src/components/content-presentation/icons/__tests__/Icons.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import React from 'react';
1+
import { HTMLProps, FC } from 'react';
22
import { render } from '@testing-library/react';
33
import * as Icons from '../';
44

55
describe('Icons', () => {
66
it('all icons match snapshots', () => {
77
Object.entries(Icons).forEach((icon) => {
88
const [name, Component] = icon;
9-
const Icon = Component as React.FC<React.HTMLProps<SVGSVGElement>>;
9+
const Icon = Component as FC<HTMLProps<SVGSVGElement>>;
1010
const { container } = render(<Icon />);
1111

1212
expect(container).toMatchSnapshot(name);

src/components/content-presentation/images/Images.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
import React from 'react';
1+
import { FC, HTMLProps } from 'react';
22
import classNames from 'classnames';
33

4-
interface ImageProps extends React.HTMLProps<HTMLImageElement> {
4+
interface ImageProps extends HTMLProps<HTMLImageElement> {
55
// Overriding the default crossOrigin the default is crossOrigin: string | undefined
66
// which causes a typescript "incompatible types" error.
77
crossOrigin?: 'anonymous' | 'use-credentials' | undefined;
88
caption?: string;
99
}
1010

11-
const Images: React.FC<ImageProps> = ({ className, caption, ...rest }) => (
11+
const Images: FC<ImageProps> = ({ className, caption, ...rest }) => (
1212
<figure className="nhsuk-image">
1313
{/* eslint-disable-next-line jsx-a11y/alt-text */}
1414
<img className={classNames('nhsuk-image__img', className)} {...rest} />

src/components/content-presentation/inset-text/InsetText.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import React from 'react';
1+
import React, { FC, HTMLProps } from 'react';
22
import classNames from 'classnames';
33

4-
interface InsetTextProps extends React.HTMLProps<HTMLDivElement> {
4+
interface InsetTextProps extends HTMLProps<HTMLDivElement> {
55
visuallyHiddenText?: string | false;
66
}
77

8-
const InsetText: React.FC<InsetTextProps> = ({
8+
const InsetText: FC<InsetTextProps> = ({
99
className,
1010
children,
1111
visuallyHiddenText = 'Information: ',

src/components/content-presentation/summary-list/SummaryList.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
1-
import React from 'react';
1+
import React, { FC, HTMLProps } from 'react';
22
import classNames from 'classnames';
33

4-
const SummaryListRow: React.FC<React.HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
4+
const SummaryListRow: FC<HTMLProps<HTMLDivElement>> = ({ className, ...rest }) => (
55
<div className={classNames('nhsuk-summary-list__row', className)} {...rest} />
66
);
77

8-
const SummaryListKey: React.FC<React.HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
8+
const SummaryListKey: FC<HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
99
<dt className={classNames('nhsuk-summary-list__key', className)} {...rest} />
1010
);
1111

12-
const SummaryListValue: React.FC<React.HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
12+
const SummaryListValue: FC<HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
1313
<dd className={classNames('nhsuk-summary-list__value', className)} {...rest} />
1414
);
1515

16-
const SummaryListActions: React.FC<React.HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
16+
const SummaryListActions: FC<HTMLProps<HTMLDListElement>> = ({ className, ...rest }) => (
1717
<dd className={classNames('nhsuk-summary-list__actions', className)} {...rest} />
1818
);
1919

20-
interface SummaryListProps extends React.HTMLProps<HTMLDListElement> {
20+
interface SummaryListProps extends HTMLProps<HTMLDListElement> {
2121
noBorder?: boolean;
2222
}
2323

24-
interface SummaryList extends React.FC<SummaryListProps> {
25-
Row: React.FC<React.HTMLProps<HTMLDivElement>>;
26-
Key: React.FC<React.HTMLProps<HTMLDListElement>>;
27-
Value: React.FC<React.HTMLProps<HTMLDListElement>>;
28-
Actions: React.FC<React.HTMLProps<HTMLDListElement>>;
24+
interface SummaryList extends FC<SummaryListProps> {
25+
Row: FC<HTMLProps<HTMLDivElement>>;
26+
Key: FC<HTMLProps<HTMLDListElement>>;
27+
Value: FC<HTMLProps<HTMLDListElement>>;
28+
Actions: FC<HTMLProps<HTMLDListElement>>;
2929
}
3030

3131
const SummaryList: SummaryList = ({ className, noBorder, ...rest }) => (

0 commit comments

Comments
 (0)