Env var the parameters, for easier admin via github

Signed-off-by: Connor Avery <[email protected]>

Author: connoravo-nhs

.github/scripts/release_code.sh

@@ -48,4 +48,7 @@ sam deploy \
       Env="$TARGET_ENVIRONMENT" \
       ToggleGetStatusUpdates="$TOGGLE_GET_STATUS_UPDATES" \
       EnableAlerts="$ENABLE_ALERTS" \
-      StateMachineLogLevel="$STATE_MACHINE_LOG_LEVEL"
+      StateMachineLogLevel="$STATE_MACHINE_LOG_LEVEL" \
+      TC007NHSNumberValue="$TC007_NHS_NUMBERS" \
+      TC008NHSNumberValue="$TC008_NHS_NUMBERS" \
+      TC009NHSNumberValue="$TC009_NHS_NUMBERS"

.github/workflows/release.yml

@@ -135,6 +135,9 @@ jobs:
       STATE_MACHINE_LOG_LEVEL: ALL
       RUN_REGRESSION_TESTS: true
       REGRESSION_TEST_PRODUCT: PFP-APIGEE
+      TC007_NHS_NUMBERS: ${{vars.TC007_NHS_NUMBERS}}
+      TC008_NHS_NUMBERS: ${{vars.TC008_NHS_NUMBERS}}
+      TC009_NHS_NUMBERS: ${{vars.TC009_NHS_NUMBERS}}
     secrets:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -162,6 +165,9 @@ jobs:
       LOG_RETENTION_DAYS: 30
       STATE_MACHINE_LOG_LEVEL: ALL
       RUN_REGRESSION_TESTS: false
+      TC007_NHS_NUMBERS: ${{vars.TC007_NHS_NUMBERS}}
+      TC008_NHS_NUMBERS: ${{vars.TC008_NHS_NUMBERS}}
+      TC009_NHS_NUMBERS: ${{vars.TC009_NHS_NUMBERS}}
     secrets:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -194,6 +200,9 @@ jobs:
       ENABLE_ALERTS: true
       STATE_MACHINE_LOG_LEVEL: ERROR
       RUN_REGRESSION_TESTS: false
+      TC007_NHS_NUMBERS: ${{vars.TC007_NHS_NUMBERS}}
+      TC008_NHS_NUMBERS: ${{vars.TC008_NHS_NUMBERS}}
+      TC009_NHS_NUMBERS: ${{vars.TC009_NHS_NUMBERS}}
     secrets:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.REF_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -227,6 +236,9 @@ jobs:
       STATE_MACHINE_LOG_LEVEL: ALL
       RUN_REGRESSION_TESTS: true
       REGRESSION_TEST_PRODUCT: PFP-APIGEE
+      TC007_NHS_NUMBERS: ${{vars.TC007_NHS_NUMBERS}}
+      TC008_NHS_NUMBERS: ${{vars.TC008_NHS_NUMBERS}}
+      TC009_NHS_NUMBERS: ${{vars.TC009_NHS_NUMBERS}}
     secrets:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.QA_CLOUD_FORMATION_DEPLOY_ROLE }}
@@ -255,6 +267,9 @@ jobs:
       STATE_MACHINE_LOG_LEVEL: ALL
       RUN_REGRESSION_TESTS: true
       REGRESSION_TEST_PRODUCT: PFP-APIGEE
+      TC007_NHS_NUMBERS: ${{vars.TC007_NHS_NUMBERS}}
+      TC008_NHS_NUMBERS: ${{vars.TC008_NHS_NUMBERS}}
+      TC009_NHS_NUMBERS: ${{vars.TC009_NHS_NUMBERS}}
     secrets:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.INT_CLOUD_FORMATION_DEPLOY_ROLE }}

.github/workflows/sam_release_code.yml

@@ -63,6 +63,15 @@ on:
         type: string
       REGRESSION_TEST_PRODUCT:
         type: string
+      TC007_NHS_NUMBERS:
+        required: false
+        type: string
+      TC008_NHS_NUMBERS:
+        required: false
+        type: string
+      TC009_NHS_NUMBERS:
+        required: false
+        type: string
     secrets:
       CLOUD_FORMATION_DEPLOY_ROLE:
         required: true
@@ -142,6 +151,9 @@ jobs:
           TOGGLE_GET_STATUS_UPDATES: ${{ inputs.TOGGLE_GET_STATUS_UPDATES }}
           ENABLE_ALERTS: ${{ inputs.ENABLE_ALERTS }}
           STATE_MACHINE_LOG_LEVEL: ${{ inputs.STATE_MACHINE_LOG_LEVEL }}
+          TC007_NHS_NUMBERS: ${{ inputs.TC007_NHS_NUMBERS }}
+          TC008_NHS_NUMBERS: ${{ inputs.TC008_NHS_NUMBERS }}
+          TC009_NHS_NUMBERS: ${{ inputs.TC009_NHS_NUMBERS }}
         run: ./release_code.sh
 
       - name: create_int_release_notes

SAMtemplates/parameters/main.yaml

@@ -8,15 +8,15 @@ Parameters:
 
   TC007NHSNumberValue:
     Type: String
-    Default: "8396901627,9661034524" # 9992387920 can be used for a default
+    Default: "123" # overcome space only issue
 
   TC008NHSNumberValue:
     Type: String
-    Default: "8618341568,7419356033" # 9992387920 can be used for a default
+    Default: "123"
 
   TC009NHSNumberValue:
     Type: String
-    Default: "8548472367,2627847198" # 9992387920 can be used for a default
+    Default: "123"
 
 Resources:
   TC007NHSNumberParameter: