Fix: show other vaccinator name in Check answers (#170)

Author: frankieroberto

app/views/vaccinate/check.html

@@ -177,7 +177,7 @@ <h2 class="nhsuk-heading-m">Vaccination</h2>
               text: "Vaccinator"
             },
             value: {
-              html: data.vaccinator
+              html: (data.otherVaccinator if data.vaccinator == "Someone else" else data.vaccinator)
             },
             actions: {
               items: [

app/views/vaccinate/vaccinator.html

@@ -28,23 +28,31 @@
 
       <form action="/vaccinate/answer-vaccinator" method="post" novalidate>
 
+        {% set otherVaccinators = [
+          {name: "James Bloggs", email: "[email protected]" },
+          {name: "James Smith", email: "[email protected]" },
+          {name: "Joan Jacobs", email: "[email protected]" }
+        ] %}
+
         {% set otherVaccinatorHtml %}
           <div class="nhsuk-form-group">
             <h1 class="nhsuk-label-wrapper">
-              <label class="nhsuk-label nhsuk-label--s nhsuk-u-margin-bottom-1" for="organisationCode">
+              <label class="nhsuk-label nhsuk-label--s nhsuk-u-margin-bottom-1" for="otherVaccinator">
                 Vaccinator
               </label>
             </h1>
             <div class="nhsuk-hint" id="organisationName-hint">
               Search by name
             </div>
-            <select class="nhsuk-select" id="siteCode" name="siteCode"
+
+            <select class="nhsuk-select" id="otherVaccinator" name="otherVaccinator"
               data-module="autocomplete" data-autoselect="" data-display-menu="" data-min-length="" data-show-all-values="" data-show-no-options-found="">
-              <option selected value=""></option>
+                <option {{ "selected" if data.otherVaccinator == "" }} value=""></option>
 
-                <option value="James Bloggs">James Bloggs ([email protected])</option>
-                <option value="James Smith">James Smith ([email protected])</option>
-                <option value="Joan Jacobs">Joan Jacobs ([email protected])</option>
+                {% for otherVaccinator in otherVaccinators %}
+                  <option {{ "selected" if data.otherVaccinator == otherVaccinator.name }}
+                  value="{{ otherVaccinator.name }}">{{ otherVaccinator.name }} ({{ otherVaccinator.email}})</option>
+                {% endfor %}
             </select>
           </div>
         {% endset %}
@@ -77,7 +85,7 @@ <h1 class="nhsuk-label-wrapper">
               divider: "or"
             },
             {
-              value: "no",
+              value: "Someone else",
               text: "Someone else",
               checked: (data.vaccinator === "Someone else"),
               conditional: {