Skip to content

Commit 2ca6ae9

Browse files
authored
Rewording on commit signing
1 parent 67dd547 commit 2ca6ae9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

practices/securing-repositories.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ This minimum set of requirements should be implemented alongside other relevant
5959
- Code reviews must be approved by at least one code owner.
6060
- You may want to require multiple code owners to review pull requests.
6161
- Commits must be <!-- markdown-link-check-disable -->[signed](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits)<!-- markdown-link-check-enable --> and verified before merging.
62-
- Git treats authentication and identity separately - any authenticated user can impersonate another developer when committing code. This means that even if a junior account is compromised it could have significant consequences, for example impersonating the lead developer in the hope of an easy merge. Only by requiring signing can identity truly be verified.
62+
- Git treats authentication and identity separately - without a signature, a git commit could have come from anyone, and the email address attached to a commit can be made up. A compromised junior account can apply the lead developer's email address to a bad commit in the hope of an easy merge to `main`. When github verifies the signature of a commit before a merge, it tells us that it was committed by who it claims to have been signed by. It may legitimately be uploaded by someone else but as long as github can verify the signature, we can be sure of the authorship.
6363
- For further details, please see [Setup Guides](guides/commit-signing.md) for macOS, Windows, GitHub Actions, and AWS CodePipeline.
6464
- Existing reviews must be invalidated automatically when new commits are pushed (using the `fresh-commits-invalidate-existing-reviews` option).
6565
- Merging must be blocked if the branch is not up to date.

0 commit comments

Comments
 (0)