Skip to content

Commit 6630d28

Browse files
authored
Code review security notes (#140)
* Code review - security notes * Update everything-as-code.md * Update everything-as-code.md * Update everything-as-code.md
1 parent dcec8b7 commit 6630d28

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

patterns/everything-as-code.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,18 @@ Robert Fink provides an excellent description of the [motivation and practice of
4545
While effective testing is the best way to detect bugs or non-functional problems, code review plays an important role in spotting _potential_ issues:
4646
* Does the code look like it will meet the acceptance criteria, or are there obvious errors or omissions?
4747
* Does it handle edge cases?
48-
* Are common issues guarded against relating to security (e.g. [OWASP Top 10](https://owasp.org/www-project-top-ten/)), performance, scalability or robustness?
4948
#### Of high quality
5049
* Is the code clear and simple?
5150
* Is the code layout and structure consistent with agreed style and other code?
5251
* Would it easily allow future modification to meet slightly different needs, e.g. ten times the required data size or throughput?
52+
* Have the non-functional requirements been considered (performance, scalability, robustness, etc)?
53+
* Are common security issues guarded against (e.g. [OWASP Top 10](https://owasp.org/www-project-top-ten/))? Including:
54+
* Is any new input data being treated as potentially hostile?
55+
* Is any data potentially leaking from the system by mistake, for example sensitive data recorded in log files?
56+
* Are there secrets in the code?
57+
* For further reading, please see the [OWASP Code Review Guide](https://owasp.org/www-pdf-archive/OWASP_Code_Review_Guide_v2.pdf)
58+
59+
Note: automated scans and tests can help to identity a lot of these quality issues (please see [Quality Checks](../quality-checks.md)) but no automated scan is perfect, so both code reviews and automated checks are essential.
5360

5461
## Examples
5562

0 commit comments

Comments
 (0)