Skip to content

Commit 9b8372a

Browse files
authored
Disable links check to 3 github links returning 403 (#266)
1 parent 134aa78 commit 9b8372a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

practices/security-repository.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ This guide lays out security best practice for Github repositories. This set of
1717
* In line with the [Service Manual](https://service-manual.nhs.uk/service-standard/12-make-new-source-code-open), new repositories should be public by default, unless there is good reason not to - this avoids costly rework to secure private information further down the line.
1818
* Private repositories must disable forking.
1919
* There must be no outside collaborators in private repositories.
20-
* Enable abuse reporting by [accepting content reports](https://docs.github.com/en/communities/moderating-comments-and-conversations/managing-how-contributors-report-abuse-in-your-organizations-repository)
20+
* Enable abuse reporting by <!-- markdown-link-check-disable -->[accepting content reports](https://docs.github.com/en/communities/moderating-comments-and-conversations/managing-how-contributors-report-abuse-in-your-organizations-repository)<!-- markdown-link-check-enable -->
2121

2222
### Teams setup
2323
Because of baseline visibility configurations, you must setup Github teams in order to provide team members access to repos. The minimum recommended setup is as follows:
@@ -34,7 +34,7 @@ Depending on your use case, you may want to create additional teams (e.g. a read
3434
* Refer to [Quality Checks](../quality-checks.md) for further code security practices.
3535

3636
### Branch protection
37-
* Require [pull request code reviews](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-pull-request-reviews-before-merging), by at least one code owner, to merge a branch.
38-
* Require [signed commits](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits), and, accordingly, check that commits are verified before merging.
37+
* Require <!-- markdown-link-check-disable -->[pull request code reviews](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-pull-request-reviews-before-merging)<!-- markdown-link-check-enable -->, by at least one code owner, to merge a branch.
38+
* Require <!-- markdown-link-check-disable -->[signed commits](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits)<!-- markdown-link-check-enable -->, and, accordingly, check that commits are verified before merging.
3939
* Invalidate existing reviews when new commits are pushed (`fresh-commits-invalidate-existing-reviews` option).
4040
* Require adequate automated status checks prior to merging. This should always include checking that branches are up to date.

0 commit comments

Comments
 (0)