#210 conventions for GitHub teams

Author: iw-ezequiel

practices/security-repository.md

@@ -10,7 +10,7 @@ This guide lays out security best practice for Github repositories. This set of
 ## Access controls
 ### Organisation-level settings
 * All users must have MFA enabled.
-* Baseline visibility for private repositories must be "no permission".
+* Baseline visibility for private repositories must be `No Permission`.
 * Ability to change repository view from private to public must be reserved to admins only.
 
 ### Repository-specific settings
@@ -19,6 +19,15 @@ This guide lays out security best practice for Github repositories. This set of
 * There must be no outside collaborators in private repositories.
 * Enable abuse reporting by [accepting content reports](https://docs.github.com/en/communities/moderating-comments-and-conversations/managing-how-contributors-report-abuse-in-your-organizations-repository)
 
+### Teams setup
+Because of baseline visibility configurations, you must setup Github teams in order to provide team members access to repos. The minimum recommended setup is as follows:
+* Create one team with the name of your programme (e.g. `Engineering Quality Framework`). Add all required members to this team.
+* Create one child team within the team, for admins only (e.g. `Engineering Quality Framework Admins`). Add admins only to this team.
+* Create a second child team, for code owners (e.g. `Engineering Quality Framework Code Owners`). Add relevant members to this team, and reference in the CODEOWNERS file (example [here](https://github.com/NHSDigital/software-engineering-quality-framework/blob/master/CODEOWNERS)).
+* For each repo in your programme (e.g. `software-engineering-quality-framework`), under the `Manage Access` option in `Settings`, set the general team to have `Write` access and the admins team to have `Admin` access.
+
+Depending on your use case, you may want to create additional teams (e.g. a read-only access team, or different teams granting access to different projects). This is welcomed by the framework, as long as the teams provide clarity on the role they encompass, remain consistent and are applied consistently to your repos.
+
 ## Code security
 * Enable, at a minimum, [Dependabot](https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/) alerts for vulnerabilities and respond to them appropriately.
 * Disable ability to push to the default branch for everyone, admins included (`applies-to-admin` option).