Skip to content

Commit cffce68

Browse files
authored
Update securing-repositories.md
1 parent 29d0c71 commit cffce68

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

practices/securing-repositories.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ This minimum set of requirements should be implemented alongside other relevant
5555

5656
- Ability to push to the default branch must be disabled for everyone, including administrators (using the `applies-to-admin` option).
5757
- Pull request <!-- markdown-link-check-disable -->[code reviews](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-pull-request-reviews-before-merging)<!-- markdown-link-check-enable --> must be required prior to merging a branch.
58-
- Code reviews must be approved by at least one code owner
58+
- Code reviews must be approved by at least one code owner.
59+
- You may want to require multiple code owners to review pull requests.
5960
- Commits must be <!-- markdown-link-check-disable -->[signed](https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits)<!-- markdown-link-check-enable -->, and verified before merging.
6061
- Git treats authentication and identity separately - any authenticated user can impersonate another developer when committing code. This means that even if a junior account is compromised it could have significant consequences, for example impersonating the lead developer in the hope of an easy merge. Only by requiring signing can identity truly be verified. [Setup Guides](guides/commit-signing.md) for macOS, Windows, GitHub Actions, and AWS CodePipeline.
6162
- Existing reviews must be invalidated automatically when new commits are pushed (using the `fresh-commits-invalidate-existing-reviews` option).

0 commit comments

Comments
 (0)