Skip to content

Commit 1129d40

Browse files
VIA-306 Updated heading, removed extra div in pregnancy vaccines card
- Updated gitleaksignore - fingerprint for false ipv4 address
1 parent 8594a1f commit 1129d40

File tree

4 files changed

+24
-26
lines changed

4 files changed

+24
-26
lines changed

.gitleaksignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ src/app/_components/nhs-app/CardLink.tsx:ipv4:30
77
4042f9b1238dd4efc8bfdee65fa4ecbd5e08504e:fake-api/data/apim/token.json:generic-api-key:2
88
4042f9b1238dd4efc8bfdee65fa4ecbd5e08504e:fake-api/data/apim/token.json:generic-api-key:6
99
src/app/api/fake-login/token/route.ts:jwt:11
10-
src/app/_components/nhs-app/CardLinkWithDescription.tsx:ipv4:30
10+
src/app/_components/nhs-app/CardLinkWithDescription.tsx:ipv4:29

src/app/_components/nhs-app/CardLinkWithDescription.tsx

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,28 @@ interface CardLinkProps {
77
const CardLinkWithDescription = ({ title, description, link }: CardLinkProps) => {
88
return (
99
<li className="nhsapp-card">
10-
<div className="nhsapp-card">
11-
<div className="nhsapp-card__container">
12-
<div className="nhsapp-card__content">
13-
<a href={link} className="nhsapp-card__link nhsuk-link--no-visited-state">
14-
{title}
15-
</a>
16-
<div className="nhsapp-card__below">
17-
<p className="nhsapp-card__description">{description}</p>
18-
</div>
10+
<div className="nhsapp-card__container">
11+
<div className="nhsapp-card__content">
12+
<a href={link} className="nhsapp-card__link nhsuk-link--no-visited-state">
13+
{title}
14+
</a>
15+
<div className="nhsapp-card__below">
16+
<p className="nhsapp-card__description">{description}</p>
1917
</div>
20-
<svg
21-
className="nhsapp-icon nhsapp-icon--chevron-right"
22-
xmlns="http://www.w3.org/2000/svg"
23-
aria-hidden="true"
24-
focusable="false"
25-
height="2rem"
26-
width="2rem"
27-
viewBox="0 0 24 24"
28-
>
29-
{" "}
30-
<path d="M8.82 19.11a.97.97 0 0 1-.72-.31.996.996 0 0 1 .03-1.41l5.61-5.38-5.6-5.25c-.4-.38-.42-1.01-.05-1.41.38-.4 1.01-.42 1.41-.05l6.37 5.97c.2.19.31.45.32.72s-.11.54-.31.73l-6.37 6.11c-.19.19-.44.28-.69.28Z" />{" "}
31-
</svg>{" "}
32-
</div>{" "}
33-
</div>
18+
</div>
19+
<svg
20+
className="nhsapp-icon nhsapp-icon--chevron-right"
21+
xmlns="http://www.w3.org/2000/svg"
22+
aria-hidden="true"
23+
focusable="false"
24+
height="2rem"
25+
width="2rem"
26+
viewBox="0 0 24 24"
27+
>
28+
{" "}
29+
<path d="M8.82 19.11a.97.97 0 0 1-.72-.31.996.996 0 0 1 .03-1.41l5.61-5.38-5.6-5.25c-.4-.38-.42-1.01-.05-1.41.38-.4 1.01-.42 1.41-.05l6.37 5.97c.2.19.31.45.32.72s-.11.54-.31.73l-6.37 6.11c-.19.19-.44.28-.69.28Z" />{" "}
30+
</svg>{" "}
31+
</div>{" "}
3432
</li>
3533
);
3634
};

src/app/check-and-book-vaccinations/page.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("Vaccination Hub Page", () => {
1414
});
1515

1616
it("renders subheading about pregnancy", () => {
17-
const subheading: HTMLElement = getHeading("Vaccines if you are pregnant", 2);
17+
const subheading: HTMLElement = getHeading("Vaccines if you're pregnant", 2);
1818
expect(subheading).toBeVisible();
1919
});
2020

src/app/check-and-book-vaccinations/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const VaccinationsHub = () => {
1212
<BackToNHSAppLink />
1313
<MainContent>
1414
<h1 className={"app-dynamic-page-title__heading"}>{SERVICE_HEADING}</h1>
15-
<h2 className="nhsuk-heading-s">Vaccines if you are pregnant</h2>
15+
<h2 className="nhsuk-heading-s">Vaccines if you&#39;re pregnant</h2>
1616
<p>Some vaccines are recommended during pregnancy to protect the health of you and your baby.</p>
1717
<ul className="nhsapp-cards nhsapp-cards--stacked" data-testid={"vaccine-cardlinks-adults"}>
1818
<CardLink title={"Vaccines during pregnancy"} link={"/vaccines-during-pregnancy"} />

0 commit comments

Comments
 (0)