VIA-433 AS/AJ Cleanup splunk tf scripts

anoop-surej-nhs · anoop-surej-nhs · commit 21439875a597 · 2025-09-16T15:07:37.000+01:00
diff --git a/infrastructure/modules/deploy_splunk/firehose.tf b/infrastructure/modules/deploy_splunk/firehose.tf
@@ -41,11 +41,11 @@ resource "aws_kinesis_firehose_delivery_stream" "splunk_log_forwarder" {
         }
         parameters {
           parameter_name  = "BufferSizeInMBs"
-          parameter_value = "0.256" # Should this be passed from main file?
+          parameter_value = "0.256"
         }
         parameters {
           parameter_name  = "BufferIntervalInSeconds"
-          parameter_value = "60" # Should this be passed from main file?
+          parameter_value = "60"
         }
       }
     }
diff --git a/infrastructure/modules/deploy_splunk/firehose_alarms.tf b/infrastructure/modules/deploy_splunk/firehose_alarms.tf
diff --git a/infrastructure/modules/deploy_splunk/lambda.tf b/infrastructure/modules/deploy_splunk/lambda.tf
@@ -13,7 +13,6 @@ module "firehose_transformer_lambda_function" {
   source_path = "${path.module}/files"
 
   cloudwatch_logs_retention_in_days = var.splunk_log_retention_in_days
-  cloudwatch_logs_skip_destroy      = true
   logging_log_format                = "JSON"
 
   tags = var.default_tags

Original file line number	Diff line number	Diff line change
`@@ -41,11 +41,11 @@ resource "aws_kinesis_firehose_delivery_stream" "splunk_log_forwarder" {`
`41`	`41`	`}`
`42`	`42`	`parameters {`
`43`	`43`	`parameter_name = "BufferSizeInMBs"`
`44`		`- parameter_value = "0.256" # Should this be passed from main file?`
	`44`	`+ parameter_value = "0.256"`
`45`	`45`	`}`
`46`	`46`	`parameters {`
`47`	`47`	`parameter_name = "BufferIntervalInSeconds"`
`48`		`- parameter_value = "60" # Should this be passed from main file?`
	`48`	`+ parameter_value = "60"`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`	`}`