TASK: MD: Replace incorrect queryBy by getBy, add missing types in tests and replace .toBeNull() by not.toBeInTheDocument()

Author: marie-dedikova-nhs

src/app/_components/eligibility/Eligibility.test.tsx

@@ -20,7 +20,7 @@ describe("Eligibility", () => {
         }),
       );
 
-      const careCard: HTMLElement | null = screen.queryByTestId("non-urgent-care-card");
+      const careCard: HTMLElement = screen.getByTestId("non-urgent-care-card");
       expect(careCard).toBeInTheDocument();
     });
 
@@ -112,7 +112,7 @@ describe("Eligibility", () => {
 
     it("should display EligibilityActions component", () => {
       render(Eligibility({ eligibilityContent: eligibilityContentBuilder().build() }));
-      const actions = screen.getByText("Test Eligibility Actions Component");
+      const actions: HTMLElement = screen.getByText("Test Eligibility Actions Component");
 
       expect(actions).toBeVisible();
     });

src/app/_components/eligibility/EligibilityActions.test.tsx

@@ -157,7 +157,7 @@ describe("EligibilityActions", () => {
           }),
         );
 
-        const authButtonComponents = screen.getByTestId("action-auth-button-components");
+        const authButtonComponents: HTMLElement = screen.getByTestId("action-auth-button-components");
 
         const card = within(authButtonComponents).queryByTestId("action-auth-button-card");
 

src/app/_components/feedback/FeedbackBanner.test.tsx

@@ -7,7 +7,7 @@ describe("FeedbackBanner", () => {
 
     render(<FeedbackBanner referrer={testReferrer} />);
 
-    const feedbackText = screen.getByText(/This is a new NHS App service\. Help us improve it and/i);
+    const feedbackText: HTMLElement = screen.getByText(/This is a new NHS App service\. Help us improve it and/i);
     const feedbackLink: HTMLAnchorElement = screen.getByRole("link", { name: "give your feedback" });
     const feedbackUrl: URL = new URL(feedbackLink.href);
 

src/app/_components/nbs/NBSBookingAction.test.tsx

@@ -23,7 +23,7 @@ describe("NBSBookingAction", () => {
           reduceBottomPadding={false}
         />,
       );
-      let bookingAction;
+      let bookingAction: HTMLElement;
       if (renderAs === "anchor") {
         bookingAction = screen.getByRole("link", { name: displayText });
       } else {

src/app/_components/nbs/PharmacyBookingInfo.test.tsx

@@ -13,7 +13,7 @@ describe("PharmacyBookingInfo", () => {
   it("should contain NBS booking with props to render as link, vaccine name and pharmacy booking text", () => {
     render(<PharmacyBookingInfo vaccineType={VaccineType.RSV} />);
 
-    const nbsBookingAction = screen.getByText("NBS Booking Link Test");
+    const nbsBookingAction: HTMLElement = screen.getByText("NBS Booking Link Test");
 
     expect(nbsBookingAction).toBeVisible();
     expect(NBSBookingActionForVaccine).toHaveBeenCalledWith(
@@ -30,7 +30,7 @@ describe("PharmacyBookingInfo", () => {
   it("should contain include correct text for older adults", () => {
     render(<PharmacyBookingInfo vaccineType={VaccineType.RSV} />);
 
-    const pharmacyBookingInfo: HTMLElement | null = screen.queryByText(
+    const pharmacyBookingInfo: HTMLElement = screen.getByText(
       /This pharmacy service is only for adults aged 75 to 79./,
     );
 

src/app/_components/nhs-app/BackToNHSAppLink.test.tsx

@@ -30,7 +30,7 @@ describe("BackToNHSAppLink", () => {
 
     it("clicking back link takes user to NHS app services page", async () => {
       render(<BackToNHSAppLink />);
-      const backLink = screen.queryByRole("link", { name: "Back" });
+      const backLink: HTMLElement = screen.getByRole("link", { name: "Back" });
       expect(backLink).toBeVisible();
       backLink?.click();
       expect(mockGoToPage).toHaveBeenCalledWith("services");
@@ -53,8 +53,8 @@ describe("BackToNHSAppLink", () => {
 
     it("back link is not rendered", async () => {
       render(<BackToNHSAppLink />);
-      const backLink = screen.queryByRole("link", { name: "Back" });
-      expect(backLink).toBeNull();
+      const backLink: HTMLElement | null = screen.queryByRole("link", { name: "Back" });
+      expect(backLink).not.toBeInTheDocument();
     });
 
     it("back action is not set", async () => {

src/app/_components/nhs-frontend/AppFooter.test.tsx

@@ -7,27 +7,27 @@ describe("AppFooter", () => {
   });
 
   it("renders crown copyright", async () => {
-    const copyright = screen.queryByText(/© NHS England/);
+    const copyright: HTMLElement = screen.getByText(/© NHS England/);
     expect(copyright).toBeVisible();
   });
 
   it("renders privacy policy", async () => {
-    const privacyPolicy = screen.queryByText(/Privacy policy/);
+    const privacyPolicy: HTMLElement = screen.getByText(/Privacy policy/);
     expect(privacyPolicy).toBeVisible();
   });
 
   it("renders help and support", async () => {
-    const helpAndSupport = screen.queryByText(/Help and support/);
+    const helpAndSupport: HTMLElement = screen.getByText(/Help and support/);
     expect(helpAndSupport).toBeVisible();
   });
 
   it("renders accessibility statement", async () => {
-    const accessibilityStatement = screen.queryByText(/Accessibility statement/);
+    const accessibilityStatement: HTMLElement = screen.getByText(/Accessibility statement/);
     expect(accessibilityStatement).toBeVisible();
   });
 
   it("renders cookies policy", async () => {
-    const cookiesPolicy = screen.queryByText(/Cookies/);
+    const cookiesPolicy: HTMLElement = screen.getByText(/Cookies/);
     expect(cookiesPolicy).toBeVisible();
   });
 });

src/app/_components/nhs-frontend/AppHeader.test.tsx

@@ -26,8 +26,8 @@ const expectHeaderVisible = (expectedVisible: boolean) => {
     expect(serviceLink).toBeVisible();
     expect(logo).toBeVisible();
   } else {
-    expect(serviceLink).toBeNull();
-    expect(logo).toBeNull();
+    expect(serviceLink).not.toBeInTheDocument();
+    expect(logo).not.toBeInTheDocument();
   }
 };
 
@@ -52,7 +52,7 @@ describe("AppHeader", () => {
       it("shows the app header with logout link", async () => {
         render(<AppHeader />);
         expectHeaderVisible(true);
-        const logoutLink = screen.getByRole("link", { name: "Log out" });
+        const logoutLink: HTMLElement = screen.getByRole("link", { name: "Log out" });
         expect(logoutLink).toBeVisible();
         expect(logoutLink?.getAttribute("href")).toEqual("#");
       });
@@ -83,8 +83,8 @@ describe("AppHeader", () => {
         mockSession = { status: "unauthenticated" };
         render(<AppHeader />);
         expectHeaderVisible(true);
-        const logoutLink = screen.queryByRole("link", { name: "Log out" });
-        expect(logoutLink).toBeNull();
+        const logoutLink: HTMLElement | null = screen.queryByRole("link", { name: "Log out" });
+        expect(logoutLink).not.toBeInTheDocument();
       });
 
       it("should not include link destination for logo and service name", async () => {

src/app/_components/vaccine/Vaccine.test.tsx

@@ -149,7 +149,7 @@ describe("Any vaccine page", () => {
     it("should display custom RSV Pregnancy vaccine component with contentApi howToGet section", async () => {
       await renderNamedVaccinePage(VaccineType.RSV_PREGNANCY);
 
-      const rsvPregnancyInfo = screen.queryByTestId("rsv-pregnancy-mock");
+      const rsvPregnancyInfo: HTMLElement = screen.getByTestId("rsv-pregnancy-mock");
 
       expect(rsvPregnancyInfo).toBeInTheDocument();
       expect(RSVPregnancyInfo).toHaveBeenCalledWith(
@@ -164,7 +164,7 @@ describe("Any vaccine page", () => {
     it("should not display RSV Pregnancy component when vaccineType is not RSV_PREGNANCY", async () => {
       await renderNamedVaccinePage(VaccineType.TD_IPV_3_IN_1);
 
-      const rsvPregnancyInfo = screen.queryByTestId("rsv-pregnancy-mock");
+      const rsvPregnancyInfo: HTMLElement | null = screen.queryByTestId("rsv-pregnancy-mock");
 
       expect(rsvPregnancyInfo).not.toBeInTheDocument();
       expect(RSVPregnancyInfo).not.toHaveBeenCalled();

src/app/session-logout/page.test.tsx

@@ -19,7 +19,7 @@ describe("SessionLogout", () => {
       </BrowserContextProvider>,
     );
     const loggedOutText = screen.queryByText("You have logged out");
-    expect(loggedOutText).toBeNull();
+    expect(loggedOutText).not.toBeInTheDocument();
     expect(mockGoToHomePage).toHaveBeenCalledTimes(1);
   });