Skip to content

Commit 2b23bb0

Browse files
VIA-227 JS Move to 5 runs averaged, log the individual values and remove dead code
1 parent b17d3db commit 2b23bb0

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

e2e/e2e-helpers.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,22 @@ export const clickLinkAndExpectPageTitle = async (page: Page, linkText: string,
55
await expect(page).toHaveTitle(expectedPageTitle);
66
}
77

8-
export const determineLargestContentfulPaint = async () => {
9-
10-
}
11-
12-
const lcpTime = async (): Promise<number> => {
8+
const lcpDuration = async (): Promise<number> => {
139
return new Promise((resolve) => {
1410
new PerformanceObserver((entryList) => {
1511
const entries = entryList.getEntries();
16-
const lastEntry = entries[entries.length - 1];
17-
resolve(lastEntry.duration);
12+
const lcpDuration = entries[entries.length -1].duration;
13+
console.log("LCP: " + lcpDuration);
14+
resolve(lcpDuration);
1815
}).observe({type: 'largest-contentful-paint', buffered: true});
1916
});
2017
}
2118

2219
export const benchmark = async (page: Page, target: string) => {
2320
const pageLoadTimes: number[] = [];
24-
for (let i = 0; i < 3; i++) {
21+
for (let i = 0; i < 5; i++) {
2522
await page.goto(target, { waitUntil: 'load' });
26-
pageLoadTimes.push(await page.evaluate(lcpTime));
23+
pageLoadTimes.push(await page.evaluate(lcpDuration));
2724
}
2825
const sumPageLoadTimes = pageLoadTimes.reduce((sum, cur) => sum + cur, 0);
2926
console.log(sumPageLoadTimes);

0 commit comments

Comments
 (0)