Skip to content

Commit 47c90b7

Browse files
VIA-598 Prevent grouping in actions from overriding failing action result with success
1 parent 9482761 commit 47c90b7

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

.github/actions/run-e2e-tests/action.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ runs:
3333
run: |
3434
echo "::group::Installing dependencies"
3535
npm ci --ignore-scripts
36+
EXIT_STATUS=$?
3637
echo "::endgroup::"
38+
exit $EXIT_STATUS
3739
3840
- name: Get current week number and playwright version
3941
shell: bash
@@ -43,7 +45,9 @@ runs:
4345
echo "::group::Get current week number and playwright version"
4446
echo "week_num=$(date -u +'%Y-%V')" | tee -a $GITHUB_OUTPUT
4547
echo "playwright_version=$(npm view @playwright/test version)" | tee -a $GITHUB_OUTPUT
48+
EXIT_STATUS=$?
4649
echo "::endgroup::"
50+
exit $EXIT_STATUS
4751
4852
- name: Cache Playwright browsers
4953
uses: actions/cache@v4
@@ -59,7 +63,9 @@ runs:
5963
run: |
6064
echo "::group::Install Playwright browsers (Chromium, Firefox)"
6165
npx playwright install chromium firefox --with-deps
66+
EXIT_STATUS=$?
6267
echo "::endgroup::"
68+
exit $EXIT_STATUS
6369
6470
- name: Install Playwright browsers (Webkit)
6571
if: ${{ inputs.cross_browser == 'true' }}
@@ -68,7 +74,9 @@ runs:
6874
run: |
6975
echo "::group::Install Playwright browsers (Webkit)"
7076
npx playwright install webkit --with-deps
77+
EXIT_STATUS=$?
7178
echo "::endgroup::"
79+
exit $EXIT_STATUS
7280
7381
- name: Run Playwright tests
7482
if: ${{ inputs.cross_browser == 'false' }}
@@ -77,7 +85,9 @@ runs:
7785
run: |
7886
echo "::group::Run Playwright tests"
7987
npm run e2e
88+
EXIT_STATUS=$?
8089
echo "::endgroup::"
90+
exit $EXIT_STATUS
8191
8292
- name: Run Playwright tests (cross browser)
8393
if: ${{ inputs.cross_browser == 'true' }}
@@ -86,7 +96,9 @@ runs:
8696
run: |
8797
echo "::group::Run Playwright tests (cross browser)"
8898
npm run e2e -- --config=playwright.config.cross-browser.ts
99+
EXIT_STATUS=$?
89100
echo "::endgroup::"
101+
exit $EXIT_STATUS
90102
91103
- name: Upload report
92104
uses: actions/upload-artifact@v5

0 commit comments

Comments
 (0)