VIA-283 AS Update workflows

- Use github.ref_name instead of parsing github.ref
- Remove ability to input tag for manual deploy workflow
- Update publish workflow to check for full SHA instead of SHORT_SHA

Author: anoop-surej-nhs

.github/workflows/cicd-2-publish.yaml

@@ -63,9 +63,6 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: "Get short SHA"
-        id: sha
-        run: echo "short_sha=$(echo ${GITHUB_SHA} | cut -c1-7)" >> $GITHUB_OUTPUT
       - name: "Configure AWS credentials"
         uses: aws-actions/configure-aws-credentials@v4
         with:
@@ -76,12 +73,12 @@ jobs:
         id: copy-artefact
         run: |
           TAG=${{ github.ref_name }}
-          SHORT_SHA=${{ steps.sha.outputs.short_sha }}
+          SHA=${{ github.sha }}
 
-          if aws s3 ls "s3://${AWS_S3_ARTEFACTS_BUCKET}/sha/$SHORT_SHA/" | grep .; then
-            aws s3 cp "s3://${AWS_S3_ARTEFACTS_BUCKET}/sha/$SHORT_SHA" "s3://${AWS_S3_RELEASES_BUCKET}/tag/$TAG/" --recursive
+          if aws s3 ls "s3://${AWS_S3_ARTEFACTS_BUCKET}/sha/$SHA/" | grep .; then
+            aws s3 cp "s3://${AWS_S3_ARTEFACTS_BUCKET}/sha/$SHA" "s3://${AWS_S3_RELEASES_BUCKET}/tag/$TAG/" --recursive
           else
-            echo "Error: No build found for SHA: $SHORT_SHA"
+            echo "Error: No build found for SHA: $SHA"
             exit 1
           fi
       - name: "Get commit history"

.github/workflows/cicd-3-deploy.yaml

@@ -7,9 +7,6 @@ on:
         description: 'Environment to deploy to'
         type: environment
         required: true
-      tag:
-        description: "The commit SHA (DEV) or version tag (higher envs) to be deployed"
-        required: true
 
 env:
   AWS_REGION: eu-west-2
@@ -32,7 +29,7 @@ jobs:
       - name: "Checkout code"
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.inputs.tag }}
+          ref: ${{ github.ref }}
       - name: "Set CI/CD variables"
         id: variables
         run: |
@@ -45,7 +42,7 @@ jobs:
           echo "terraform_version=$(grep "^terraform" .tool-versions | cut -f2 -d' ')" >> $GITHUB_OUTPUT
           # TODO: Get the version, but it may not be the .version file as this should come from the CI/CD Pull Request Workflow
           echo "version=$(head -n 1 .version 2> /dev/null || echo unknown)" >> $GITHUB_OUTPUT
-          echo "tag=${{ github.event.inputs.tag }}" >> $GITHUB_OUTPUT
+          echo "tag=${{ github.ref_name }})" >> $GITHUB_OUTPUT
       - name: "List variables"
         run: |
           export BUILD_DATETIME="${{ steps.variables.outputs.build_datetime }}"

.github/workflows/stage-4-deploy.yaml

@@ -8,7 +8,7 @@ on:
         type: string
       tag:
         description: "The commit SHA (DEV) or version tag (higher envs) to be deployed"
-        required: false
+        required: true
         type: string
       environment:
         description: "Environment to deploy to"
@@ -17,7 +17,7 @@ on:
 
 env:
   AWS_REGION: eu-west-2
-  TAG: ${{ inputs.tag || github.sha }}
+  TAG: ${{ inputs.tag }}
 
 jobs:
   deploy: