VIA-579 AJ Upgrade infrastructure (other environments) and add step to README

Author: ankur-jain-nhs

infrastructure/README.md

@@ -292,11 +292,13 @@ To upgrade terraform itself and its module versions, it requires careful process
 - repeat the following for each incremental upgrade
   - upgrade - starting with the provider and then moving to third party modules, bump the version to next major version
   - do the "reset local environment" steps above
-  - terraform init --upgrade
+  - terraform init -upgrade
   - terraform providers lock -platform=linux_amd64 -platform=linux_arm64q
   - do the "build and deploy to your workspace" steps above
 - expect that no changes to your infrastructure are needed
 
+Once done for dev environment, just replay the upgrade changes needed in other environments.
+
 ## OpenNext
 
 OpenNext takes the Next.js build output and converts it into packages that can be deployed across a variety of environments.

infrastructure/environments/preprod/.terraform.lock.hcl

@@ -2,7 +2,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = "~> 5.0"
+      version = "~> 6.0"
     }
   }
 

infrastructure/environments/preprod/iam/.terraform.lock.hcl

@@ -2,7 +2,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = "~> 5.0"
+      version = "~> 6.0"
     }
   }
 

infrastructure/environments/preprod/iam/provider.tf

@@ -1,9 +1,10 @@
 module "content_cache_s3_bucket" {
   source  = "terraform-aws-modules/s3-bucket/aws"
-  version = "~> 4.11.0"
+  version = "~> 5.0"
 
-  bucket        = local.content_cache_bucket_name
-  force_destroy = true
+  bucket                           = local.content_cache_bucket_name
+  force_destroy                    = true
+  skip_destroy_public_access_block = false
   versioning = {
     enabled = true
   }