VIA-598 AJ Fix IDE warnings and log LCP for info purposes

ankur-jain-nhs · ankur-jain-nhs · commit 9204ca594b9d · 2025-11-25T12:30:29.000Z
diff --git a/e2e/helpers.ts b/e2e/helpers.ts
@@ -58,14 +58,15 @@ export const benchmark = async (page: Page, target: string) => {
     await page.waitForTimeout(1000);
 
     const lcp = await page.evaluate(() => window.__lcp);
-    if (typeof lcp !== "number" || lcp < 0) {
+    if (lcp < 0) {
       throw new Error(`⚠️ LCP not collected for iteration ${i}`);
     }
 
     pageLoadTimes.push(lcp);
   }
 
   const averageLCP = pageLoadTimes.reduce((sum, cur) => sum + cur, 0) / pageLoadTimes.length;
+  console.log("Average LCP", page.url(), averageLCP);
   return averageLCP;
 };
 

Original file line number	Diff line number	Diff line change
`@@ -58,14 +58,15 @@ export const benchmark = async (page: Page, target: string) => {`
`58`	`58`	`await page.waitForTimeout(1000);`
`59`	`59`
`60`	`60`	`const lcp = await page.evaluate(() => window.__lcp);`
`61`		`- if (typeof lcp !== "number" \|\| lcp < 0) {`
	`61`	`+ if (lcp < 0) {`
`62`	`62`	throw new Error(`⚠️ LCP not collected for iteration ${i}`);
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`pageLoadTimes.push(lcp);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`const averageLCP = pageLoadTimes.reduce((sum, cur) => sum + cur, 0) / pageLoadTimes.length;`
	`69`	`+ console.log("Average LCP", page.url(), averageLCP);`
`69`	`70`	`return averageLCP;`
`70`	`71`	`};`
`71`	`72`