VIA-537 SB & AS Fix URL concatenation in getSSOUrlToNBSForVaccine().

Author: acerathereinspirative-nhs-nvir

src/services/nbs/nbs-service.test.ts

@@ -9,7 +9,7 @@ jest.mock("@src/utils/auth/generate-auth-payload", () => ({
 }));
 jest.mock("sanitize-data", () => ({ sanitize: jest.fn() }));
 
-const nbsUrlFromConfig = new URL("https://test-nbs-url");
+const nbsUrlFromConfig = new URL("https://test-nbs-url.example.com/sausages");
 const nbsBookingPathFromConfig = "/test/path/book";
 
 const mockAssertedLoginIdentityJWT = "mock-jwt";
@@ -31,7 +31,8 @@ describe("getSSOUrlToNBSForVaccine", () => {
     it("returns sso url of NBS configured in config for RSV vaccine", async () => {
       const nbsRedirectUrl = new URL(await getSSOUrlToNBSForVaccine(VaccineType.RSV));
       expect(nbsRedirectUrl.origin).toEqual(nbsUrlFromConfig.origin);
-      expect(nbsRedirectUrl.pathname).toEqual(`${nbsBookingPathFromConfig}/rsv`);
+      expect(nbsRedirectUrl.pathname).toEqual(`/sausages${nbsBookingPathFromConfig}/rsv`);
+      expect(nbsRedirectUrl.href).toMatch(/^https:\/\/test-nbs-url\.example\.com\/sausages\/test\/path\/book\/rsv.*/);
     });
 
     it("should include campaignID query param in NBS URL", async () => {

src/services/nbs/nbs-service.ts

@@ -26,10 +26,9 @@ const nbsVaccinePath: Record<VaccinesWithNBSBookingAvailable, string> = {
 const getSSOUrlToNBSForVaccine = async (vaccineType: VaccinesWithNBSBookingAvailable) => {
   let redirectUrl;
   try {
-    const nbsURl = new URL(
-      `${await lazyConfig.NBS_BOOKING_PATH}${nbsVaccinePath[vaccineType]}`,
-      (await lazyConfig.NBS_URL) as URL,
-    );
+    const nbsBaseUrl = (await lazyConfig.NBS_URL) as URL;
+    const nbsBookingPath = await lazyConfig.NBS_BOOKING_PATH;
+    const nbsURl = new URL(`${nbsBaseUrl.pathname}${nbsBookingPath}${nbsVaccinePath[vaccineType]}`, nbsBaseUrl.origin);
     const nbsQueryParams = await getNbsQueryParams();
     nbsQueryParams.forEach((param) => {
       nbsURl.searchParams.append(param.name, param.value);