VIA-601 AJ/MD Fix snapshot tests for static page

Author: ankur-jain-nhs

e2e/constants.ts

@@ -188,7 +188,7 @@ export const AppPageDetails: Record<PageName, PageDetails> = {
     url: "/assets/static/service-failure.html",
     heading: "There is a problem with the service",
     title: `There is a problem with the service - ${SERVICE_HEADING} - ${NHS_TITLE_SUFFIX}`,
-    snapshotFilename: "default-service-failure.png",
+    snapshotFilename: "default-service-failure-static.png",
   },
   "not-found": {
     url: "/page-does-not-exist",

e2e/snapshot/app.snapshot.spec.ts

@@ -14,7 +14,11 @@ const testPageSnapshot = async (
 ) => {
   const screenshotPath: string = pathForCustomScreenshots(testFileName, snapshotFileName, projectName);
   await page.goto(pageRoute);
-  await page.getByRole("link", { name: "Log out" }).waitFor();
+
+  // wait for specific elements on the page, as they may take longer to load
+  if (pageRoute !== AppPageDetails["service-failure-static"].url) {
+    await page.getByRole("link", { name: "Log out" }).waitFor();
+  }
 
   await openExpandersIfPresent(page);