VIA-574 AS/DB Ensure E2E tests wait for OTP page to load fully before proceeding

donna-belsey-nhs · ankur-jain-nhs · commit c7cfeb0dced2 · 2025-10-27T11:32:16.000Z
Fixes issue seen after NHS Login update where calls to /otp returns 404 with a 'transaction ID missing' error. (cherry picked from commit 948c888)
diff --git a/e2e/auth.ts b/e2e/auth.ts
@@ -69,7 +69,7 @@ export const login = async (browser: Browser, nhsLoginUsername: string): Promise
     await page.getByRole("button", { name: "Continue" }).click();
   }
 
-  await page.waitForURL("**/enter-mobile-code", { timeout: 30000 });
+  await page.waitForURL("**/enter-mobile-code", { waitUntil: "networkidle", timeout: 30000 });
   await page.getByRole("textbox", { name: "Security code" }).evaluate((input: HTMLInputElement, fillText) => {
     input.value = fillText;
     input.dispatchEvent(new Event("input"));

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export const login = async (browser: Browser, nhsLoginUsername: string): Promise`
`69`	`69`	`await page.getByRole("button", { name: "Continue" }).click();`
`70`	`70`	`}`
`71`	`71`
`72`		`- await page.waitForURL("**/enter-mobile-code", { timeout: 30000 });`
	`72`	`+ await page.waitForURL("**/enter-mobile-code", { waitUntil: "networkidle", timeout: 30000 });`
`73`	`73`	`await page.getByRole("textbox", { name: "Security code" }).evaluate((input: HTMLInputElement, fillText) => {`
`74`	`74`	`input.value = fillText;`
`75`	`75`	`input.dispatchEvent(new Event("input"));`