Commit 5bf8286
authored
NPA-4621: Self Serve API Proxy Releases (#274)
# Pull Request
## 🧾 Ticket Link
<!-- Add the Jira ticket link here -->
https://nhsd-jira.digital.nhs.uk/browse/NPA-4621
---
## 📄 Description/Summary of Changes
<!-- Describe the changes made in this PR. Include the
purpose/scope/impact of the changes -->
- Added prod self approve option in
- Messaged APIM/Service Now to created new Azure admin group so we can
assign access like we do for PVRS releases
- Group has since been created
---
## 🧪 Developer Testing Carried Out
<!-- Describe what tests (automated/unit/manual etc.) have been done for
the ticket. Include: -->
<!-- - Any tests added/updated -->
<!-- - Evidence that each acceptance criterion from the Jira ticket is
met -->
- <!-- Add bullet points for testing instructions -->
- <!-- Add bullet points for testing instructions -->
- <!-- Add bullet points for testing instructions -->
---
## 🧪 Reviewer Testing Required
<!-- Describe how to test the changes that have been made in the ticket.
Include: -->
<!-- - Testing environment details (e.g. sandbox/local setup) -->
<!-- - Steps to verify the changes -->
- [ ] <!-- Add bullet points for testing instructions -->
- [ ] <!-- Add bullet points for testing instructions -->
- [ ] <!-- Add bullet points for testing instructions -->
---
## ✅ Developer Checklist
<!-- Complete before submitting the PR -->
- [x] PR title follows the format: `NPA-XXXX: <short-description>`
- [x] Branch name follows the convention:
`<type>/NPA-XXXX/<short-description>`
- [x] Commit messages follow the template: `NPA-XXXX:
<short-description>`
- [x] All acceptance criteria from the Jira ticket are addressed
- [x] Automated tests (unit/integration/API/infrastructure etc. tests)
are added or updated
- [x] Assignees and appropriate labels (e.g. `terraform`,
`documentation`) are added
---
## 👀 Reviewer Checklist
<!-- To be completed by the reviewer -->
- [ ] Changes meet the acceptance criteria of the Jira ticket
- [ ] Code is able to be merged (no conflicts and adheres to coding
standards)
- [ ] Sufficient test evidence is provided (manual and/or automated)
- [ ] Infrastructure/operational/build changes are validated (if
applicable)
---
## 🚀 Post-merge
<!-- Actions to complete after merging -->
After merging and deploying changes to the sandbox, Postman collection
or spec examples please run the Run Postman
collection workflow.
This will run the tests within the collection to check that the sandbox
is working as expected once deployed.1 parent acd6564 commit 5bf8286
1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
0 commit comments