Skip to content

Commit 6a4392a

Browse files
committed
chore: reverted changes to workflows and updated pr template
1 parent 0e08678 commit 6a4392a

File tree

3 files changed

+25
-19
lines changed

3 files changed

+25
-19
lines changed

.github/pull_request_template.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## Pull Request Checklist
1+
# Pull Request Checklist
22

33
## Ticket Link
44

@@ -14,7 +14,7 @@ https://nhsd-jira.digital.nhs.uk/browse/NPA-XXXX
1414
-
1515
-
1616

17-
# How to test?
17+
## How to test?
1818

1919
<!--- Describe in detail how you tested your changes -->
2020
<!--- Include details of your testing environment and the tests you ran to see how your change affects other areas of the code etc. -->
@@ -37,3 +37,9 @@ Stages to complete before opening the Pull Request:
3737
- [ ] I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
3838
- [ ] If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
3939
- [ ] I have ensured the changelog has been updated by the submitter, if necessary.
40+
41+
## Post-merge
42+
43+
After merging and deploying changes to the sandbox, Postman collection or spec examples please run the `Run Postman collection` workflow.
44+
45+
This will run the tests within the collection to check that the sandbox is working as expected once deployed.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Run postman collection
2+
on:
3+
workflow_dispatch:
4+
jobs:
5+
run-postman-collection:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- name: Check out the repository
9+
uses: actions/checkout@v4
10+
- name: Set up Node.js
11+
uses: actions/setup-node@v4
12+
with:
13+
node-version: '22'
14+
- name: Install Newman
15+
run: npm install -g newman
16+
- name: Run Postman Collection
17+
run: newman run ./postman/Validate_Relationship_Service_Sandbox.postman_collection.json

.github/workflows/sandbox-checks.yaml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,3 @@ jobs:
2323
run: make lint
2424
- name: Run Sandbox Unit Tests
2525
run: make test
26-
working-directory: ./sandbox
27-
- name: Set up Node.js
28-
uses: actions/setup-node@v4
29-
with:
30-
node-version: '22'
31-
- name: Install Newman
32-
run: npm install -g newman
33-
- name: Start dev sandbox
34-
run: |
35-
make start &
36-
sleep 5
37-
working-directory: ./sandbox
38-
- name: Run Postman Collection
39-
run: newman run ./postman/Validate_Relationship_Service_Sandbox.postman_collection.json -d ./postman/dev-variables.json
40-
- name: Stop sandbox
41-
if: success() || failure()
42-
run: pkill -f "poetry run flask"

0 commit comments

Comments
 (0)