NPA-4474 Fix Unit Tests

Author: JackPlowman

sandbox/api/tests/test_app.py

@@ -12,7 +12,7 @@
 
 UTILS_FILE_PATH = "sandbox.api.utils"
 APP_FILE_PATH = "sandbox.api.app"
-
+CONSENT_FILE_PATH = "sandbox.api.get_consent"
 
 @pytest.mark.parametrize("endpoint", ["/_status", "/_ping", "/health"])
 def test_health_check(client: object, endpoint: str) -> None:
@@ -154,7 +154,7 @@ def test_questionnaire_response(
         ),
     ],
 )
-@patch(f"{APP_FILE_PATH}.generate_response_from_example")
+@patch(f"{CONSENT_FILE_PATH}.generate_response_from_example")
 def test_consent(
     mock_generate_response_from_example: MagicMock,
     request_args: str,
@@ -176,8 +176,8 @@ def test_consent(
     assert response.json == loads(mocked_response.get_data(as_text=True))
 
 
-@patch(f"{APP_FILE_PATH}.remove_system")
-@patch(f"{APP_FILE_PATH}.generate_response_from_example")
+@patch(f"{CONSENT_FILE_PATH}.remove_system")
+@patch(f"{CONSENT_FILE_PATH}.generate_response_from_example")
 def test_consent__500_internal_server_error(
     mock_generate_response_from_example: MagicMock,
     mock_remove_system: MagicMock,

sandbox/api/tests/test_utils.py

@@ -8,7 +8,6 @@
 from .conftest import CONSENT_API_ENDPOINT, RELATED_PERSON_API_ENDPOINT
 
 FILE_PATH = "sandbox.api.utils"
-GET_CONSENT_FILE_PATH = "sandbox.api.get_consent"
 
 @pytest.mark.parametrize(
     "request_args,response_file_name,status_code",
@@ -221,7 +220,7 @@ def test_check_for_related_person_errors(
         ),
     ],
 )
-@patch(f"{GET_CONSENT_FILE_PATH}.generate_response_from_example")
+@patch(f"{FILE_PATH}.generate_response_from_example")
 def test_check_for_consent_errors(
     mock_generate_response_from_example: MagicMock,
     request_args: str,