Skip to content

Commit abef3a9

Browse files
authored
NPA-6074: Update python version to v3.13 (#276)
# Pull Request ## 🧾 Ticket Link <!-- Add the Jira ticket link here --> https://nhsd-jira.digital.nhs.uk/browse/NPA-6074 --- ## 📄 Description/Summary of Changes <!-- Describe the changes made in this PR. Include the purpose/scope/impact of the changes --> - Update python version in the GitHub actions workflows to ensure that we can continue to run the create release pipeline in Azure (which APIM have upgraded to 3.13). --- ## 🧪 Developer Testing Carried Out <!-- Describe what tests (automated/unit/manual etc.) have been done for the ticket. Include: --> <!-- - Any tests added/updated --> <!-- - Evidence that each acceptance criterion from the Jira ticket is met --> - Run CI/CD pipelines --- ## 🧪 Reviewer Testing Required <!-- Describe how to test the changes that have been made in the ticket. Include: --> <!-- - Testing environment details (e.g. sandbox/local setup) --> <!-- - Steps to verify the changes --> - [ ] Review CI/CD pipelines --- ## ✅ Developer Checklist <!-- Complete before submitting the PR --> - [x] PR title follows the format: `NPA-XXXX: <short-description>` - [x] Branch name follows the convention: `<type>/NPA-XXXX/<short-description>` - [x] Commit messages follow the template: `NPA-XXXX: <short-description>` - [x] All acceptance criteria from the Jira ticket are addressed - [x] Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated - [x] Assignees and appropriate labels (e.g. `terraform`, `documentation`) are added --- ## 👀 Reviewer Checklist <!-- To be completed by the reviewer --> - [ ] Changes meet the acceptance criteria of the Jira ticket - [ ] Code is able to be merged (no conflicts and adheres to coding standards) - [ ] Sufficient test evidence is provided (manual and/or automated) - [ ] Infrastructure/operational/build changes are validated (if applicable) --- ## 🚀 Post-merge <!-- Actions to complete after merging --> After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow. This will run the tests within the collection to check that the sandbox is working as expected once deployed. --------- Signed-off-by: adamclarkson <[email protected]>
1 parent 6ce3f08 commit abef3a9

File tree

10 files changed

+2160
-1935
lines changed

10 files changed

+2160
-1935
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
with:
1313
fetch-depth: 0 # This causes all history to be fetched, which is required for calculate-version to function
1414

15-
- name: Install Python 3.8
15+
- name: Install Python 3.13
1616
uses: actions/setup-python@v6
1717
with:
18-
python-version: 3.8
18+
python-version: 3.13
1919

2020
- name: Upgrade python pip
2121
run: python -m pip install --upgrade pip

.github/workflows/openapi-validate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- name: Set up Python
5353
uses: actions/setup-python@v6
5454
with:
55-
python-version: 3.9
55+
python-version: 3.13
5656

5757
- name: Install Poetry
5858
shell: bash

.github/workflows/sandbox-checks.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
run: pipx install poetry
1111
- uses: actions/setup-python@v6
1212
with:
13-
python-version: "3.8"
13+
python-version: "3.13"
1414
cache: "poetry"
1515
- name: Install Sandbox dependencies
1616
run: make install

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.8
1+
FROM python:3.13
22

33
COPY ./specification/examples/responses /sandbox/api/examples
44
COPY ./sandbox /sandbox

poetry.lock

Lines changed: 1760 additions & 1524 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@ homepage = "https://digital.nhs.uk/developer/api-catalogue"
1212
keywords = ["healthcare", "uk", "nhs"] #TODO add additional keywords
1313

1414
[tool.poetry.dependencies]
15-
python = "^3.8"
15+
python = "^3.13"
1616

1717
[tool.poetry.group.ci.dependencies]
18-
flake8 = "^3.7.9"
18+
flake8 = "^7.3.0"
1919
black = "^24.3.0"
2020

2121
[tool.poetry.group.test.dependencies]
2222
pytest-nhsd-apim = "^5.0.0"
2323

2424
[tool.poetry.group.dev.dependencies]
25-
flake8 = "^3.7.9"
25+
flake8 = "^7.3.0"
2626
black = "^24.3.0"
2727
pip-licenses = "^4.4.0"
2828
jinja2 = "^3.1.6"

sandbox/poetry.lock

Lines changed: 358 additions & 390 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sandbox/pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ authors = []
66
package-mode = false
77

88
[tool.poetry.dependencies]
9-
python = "^3.8"
9+
python = "^3.13"
1010
gunicorn = "^23.0.0"
1111
flask = "3.0.3" # Can't bump flask due to dropping support for Python 3.8
1212
pyyaml = "^6.0.2"
1313

1414
[tool.poetry.dev-dependencies]
15-
flake8 = "^3.7.9"
15+
flake8 = "^7.3.0"
1616
black = "^24.3.0"
1717
pytest = "^8.1.1"
1818
pytest-cov = "^5.0.0"

scripts/poetry.lock

Lines changed: 31 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ readme = "README.md"
44
package-mode = false
55

66
[tool.poetry.dependencies]
7-
python = "^3.12"
7+
python = "^3.13"
88
pytest-nhsd-apim = "^5.0.0"
99

1010

0 commit comments

Comments
 (0)