NPA-5191: Add new test

Author: LeoKHoward

sandbox/api/constants.py

@@ -93,7 +93,8 @@
 # POST QuestionnaireResponse
 POST_QUESTIONNAIRE_RESPONSE_DIRECTORY = "./api/examples/POST_QuestionnaireResponse/"
 POST_QUESTIONNAIRE_RESPONSE__SUCCESS = f"{POST_QUESTIONNAIRE_RESPONSE_DIRECTORY}success.yaml"
-POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR = f"{POST_QUESTIONNAIRE_RESPONSE_DIRECTORY}errors/duplicate_relationship_error.yaml"
+POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR = \
+    f"{POST_QUESTIONNAIRE_RESPONSE_DIRECTORY}errors/duplicate_relationship_error.yaml"
 
 # GET QuestionnaireResponse
 GET_QUESTIONNAIRE_RESPONSE_DIRECTORY = "./api/examples/GET_QuestionnaireResponse/"

sandbox/api/post_questionnaire_response.py

@@ -1,7 +1,13 @@
 from logging import INFO, basicConfig, getLogger
 from typing import Union
 
-from .constants import INTERNAL_SERVER_ERROR_EXAMPLE, POST_QUESTIONNAIRE_RESPONSE__SUCCESS
+from flask import request
+
+from .constants import (
+    INTERNAL_SERVER_ERROR_EXAMPLE,
+    POST_QUESTIONNAIRE_RESPONSE__SUCCESS,
+    POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR,
+)
 from .utils import generate_response_from_example
 
 basicConfig(level=INFO, format="%(asctime)s - %(message)s")
@@ -15,7 +21,24 @@ def post_questionnaire_response_response() -> Union[dict, tuple]:
         Union[dict, tuple]: Response for POST /QuestionnaireResponse
     """
     try:
-        return generate_response_from_example(POST_QUESTIONNAIRE_RESPONSE__SUCCESS, 200)
+        logger.debug("Received request to POST questionnaire response")
+        # Validate body - beyond the scope of sandbox - assume body is valid for scenario
+        json = request.get_json()
+        source_identifier = json.get("source", {}).get("identifier", {}).get("value")
+        response = None
+
+        # Successful questionnaire response
+        if source_identifier in ["9000000009", "9000000017"]:  # Example NHS numbers for success
+            response = generate_response_from_example(POST_QUESTIONNAIRE_RESPONSE__SUCCESS, 200)
+        # Duplicate relationship
+        elif source_identifier == "9000000049":
+            response = generate_response_from_example(POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR, 409)
+        else:
+            # Out of scope errors
+            raise ValueError("Invalid Request")
+
+        return response
+
     except Exception:
         logger.exception("POST questionnaire response failed")
         return generate_response_from_example(INTERNAL_SERVER_ERROR_EXAMPLE, 500)

sandbox/api/tests/test_post_questionnaire_response.py

@@ -4,36 +4,54 @@
 import pytest
 from flask import Response
 
+from sandbox.api.constants import (
+    POST_QUESTIONNAIRE_RESPONSE__SUCCESS,
+    POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR,
+)
+
 QUESTIONNAIRE_RESPONSE_API_ENDPOINT = "/FHIR/R4/QuestionnaireResponse"
 
 
 @pytest.mark.parametrize(
-    ("url_path", "response_file_name", "status_code"),
+    ("nhs_num", "response_file_name", "status_code"),
     [
         (
-            QUESTIONNAIRE_RESPONSE_API_ENDPOINT,
-            "./api/examples/POST_QuestionnaireResponse/success.yaml",
+            "9000000009",
+            POST_QUESTIONNAIRE_RESPONSE__SUCCESS,
             200,
         ),
+        (
+            "9000000049",
+            POST_QUESTIONNAIRE_RESPONSE__DUPLICATE_RELATIONSHIP_ERROR,
+            409,
+        ),
     ],
 )
 @patch("sandbox.api.post_questionnaire_response.generate_response_from_example")
 def test_post_questionnaire_response(
     mock_generate_response_from_example: MagicMock,
-    url_path: str,
+    nhs_num: str,
     response_file_name: str,
-    client: object,
     status_code: int,
+    client: object,
 ) -> None:
-    """Test related_persons endpoint with identifier only."""
+    """Test POST QuestionnaireResponse endpoint with different scenarios."""
     # Arrange
     mock_generate_response_from_example.return_value = mocked_response = Response(
         dumps({"data": "mocked"}),
         status=status_code,
         content_type="application/json",
     )
+    json = {
+        "resourceType": "QuestionnaireResponse",
+        "source": {
+            "identifier": {
+                "value": nhs_num
+            }
+        }
+    }
     # Act
-    response = client.post(url_path, json={"data": "mocked"})
+    response = client.post(QUESTIONNAIRE_RESPONSE_API_ENDPOINT, json=json)
     # Assert
     mock_generate_response_from_example.assert_called_once_with(response_file_name, status_code)
     assert response.status_code == status_code