Skip to content

Commit c602628

Browse files
simonsteadsimonstead
committed
PR review notes, update examples and 4XX codes, add examples for GET QR
1 parent bff2758 commit c602628

File tree

7 files changed

+337
-427
lines changed

7 files changed

+337
-427
lines changed

‎.github/workflows/openapi-validate.yml‎

Lines changed: 158 additions & 132 deletions
Original file line numberDiff line numberDiff line change
@@ -1,136 +1,162 @@
11
name: Open API Validate
22
"on":
3-
pull_request:
4-
branches: [master]
3+
pull_request:
4+
branches: [master]
55
permissions:
6-
contents: read
6+
contents: read
77
jobs:
8-
GET_Consent:
9-
name: GET Consent test
10-
runs-on: ubuntu-latest
11-
steps:
12-
- name: Checkout repository
13-
uses: actions/checkout@v4
14-
15-
- name: Set up Python
16-
uses: actions/setup-python@v5
17-
with:
18-
python-version: 3.9
19-
20-
- name: Install Poetry
21-
shell: bash
22-
run: |
23-
pipx install poetry==1.8.5
24-
25-
- name: Install Script Packages with Poetry
26-
shell: bash
27-
run: |
28-
poetry install --all-extras
29-
30-
- name: Run Python script for all files
31-
run: |
32-
make schema-get-consent
33-
34-
POST_Consent:
35-
name: POST Consent test
36-
runs-on: ubuntu-latest
37-
steps:
38-
- name: Checkout repository
39-
uses: actions/checkout@v4
40-
41-
- name: Set up Python
42-
uses: actions/setup-python@v5
43-
with:
44-
python-version: 3.9
45-
46-
- name: Install Poetry
47-
shell: bash
48-
run: |
49-
pipx install poetry==1.8.5
50-
51-
- name: Install Script Packages with Poetry
52-
shell: bash
53-
run: |
54-
poetry install --all-extras
55-
56-
- name: Run Python script for all files
57-
run: |
58-
make schema-post-consent
59-
60-
GET_RelatedPerson:
61-
name: GET Related Person test
62-
runs-on: ubuntu-latest
63-
steps:
64-
- name: Checkout repository
65-
uses: actions/checkout@v4
66-
67-
- name: Set up Python
68-
uses: actions/setup-python@v5
69-
with:
70-
python-version: 3.9
71-
72-
- name: Install Poetry
73-
shell: bash
74-
run: |
75-
pipx install poetry==1.8.5
76-
77-
- name: Install Script Packages with Poetry
78-
shell: bash
79-
run: |
80-
poetry install --all-extras
81-
82-
- name: Run Python script for all files
83-
run: |
84-
make schema-related-person
85-
86-
POST_Questionnaire:
87-
name: POST questionnaire test
88-
runs-on: ubuntu-latest
89-
steps:
90-
- name: Checkout repository
91-
uses: actions/checkout@v4
92-
93-
- name: Set up Python
94-
uses: actions/setup-python@v5
95-
with:
96-
python-version: 3.9
97-
98-
- name: Install Poetry
99-
shell: bash
100-
run: |
101-
pipx install poetry==1.8.5
102-
103-
- name: Install Script Packages with Poetry
104-
shell: bash
105-
run: |
106-
poetry install --all-extras
107-
108-
- name: Run Python script for all files
109-
run: |
110-
make schema-questionnaire
111-
112-
Errors:
113-
name: Error schema test
114-
runs-on: ubuntu-latest
115-
steps:
116-
- name: Checkout repository
117-
uses: actions/checkout@v4
118-
119-
- name: Set up Python
120-
uses: actions/setup-python@v5
121-
with:
122-
python-version: 3.9
123-
124-
- name: Install Poetry
125-
shell: bash
126-
run: |
127-
pipx install poetry==1.8.5
128-
129-
- name: Install Script Packages with Poetry
130-
shell: bash
131-
run: |
132-
poetry install --all-extras
133-
134-
- name: Run Python script for all files
135-
run: |
136-
make schema-errors
8+
GET_Consent:
9+
name: GET Consent test
10+
runs-on: ubuntu-latest
11+
steps:
12+
- name: Checkout repository
13+
uses: actions/checkout@v4
14+
15+
- name: Set up Python
16+
uses: actions/setup-python@v5
17+
with:
18+
python-version: 3.9
19+
20+
- name: Install Poetry
21+
shell: bash
22+
run: |
23+
pipx install poetry==1.8.5
24+
25+
- name: Install Script Packages with Poetry
26+
shell: bash
27+
run: |
28+
poetry install --all-extras
29+
30+
- name: Run Python script for all files
31+
run: |
32+
make schema-get-consent
33+
34+
POST_Consent:
35+
name: POST Consent test
36+
runs-on: ubuntu-latest
37+
steps:
38+
- name: Checkout repository
39+
uses: actions/checkout@v4
40+
41+
- name: Set up Python
42+
uses: actions/setup-python@v5
43+
with:
44+
python-version: 3.9
45+
46+
- name: Install Poetry
47+
shell: bash
48+
run: |
49+
pipx install poetry==1.8.5
50+
51+
- name: Install Script Packages with Poetry
52+
shell: bash
53+
run: |
54+
poetry install --all-extras
55+
56+
- name: Run Python script for all files
57+
run: |
58+
make schema-post-consent
59+
60+
GET_RelatedPerson:
61+
name: GET Related Person test
62+
runs-on: ubuntu-latest
63+
steps:
64+
- name: Checkout repository
65+
uses: actions/checkout@v4
66+
67+
- name: Set up Python
68+
uses: actions/setup-python@v5
69+
with:
70+
python-version: 3.9
71+
72+
- name: Install Poetry
73+
shell: bash
74+
run: |
75+
pipx install poetry==1.8.5
76+
77+
- name: Install Script Packages with Poetry
78+
shell: bash
79+
run: |
80+
poetry install --all-extras
81+
82+
- name: Run Python script for all files
83+
run: |
84+
make schema-related-person
85+
86+
POST_Questionnaire:
87+
name: POST questionnaire test
88+
runs-on: ubuntu-latest
89+
steps:
90+
- name: Checkout repository
91+
uses: actions/checkout@v4
92+
93+
- name: Set up Python
94+
uses: actions/setup-python@v5
95+
with:
96+
python-version: 3.9
97+
98+
- name: Install Poetry
99+
shell: bash
100+
run: |
101+
pipx install poetry==1.8.5
102+
103+
- name: Install Script Packages with Poetry
104+
shell: bash
105+
run: |
106+
poetry install --all-extras
107+
108+
- name: Run Python script for all files
109+
run: |
110+
make schema-questionnaire
111+
112+
GET_Questionnaire:
113+
name: GET questionnaire test
114+
runs-on: ubuntu-latest
115+
steps:
116+
- name: Checkout repository
117+
uses: actions/checkout@v4
118+
119+
- name: Set up Python
120+
uses: actions/setup-python@v5
121+
with:
122+
python-version: 3.9
123+
124+
- name: Install Poetry
125+
shell: bash
126+
run: |
127+
pipx install poetry==1.8.5
128+
129+
- name: Install Script Packages with Poetry
130+
shell: bash
131+
run: |
132+
poetry install --all-extras
133+
134+
- name: Run Python script for all files
135+
run: |
136+
make schema-get-questionnaire
137+
138+
Errors:
139+
name: Error schema test
140+
runs-on: ubuntu-latest
141+
steps:
142+
- name: Checkout repository
143+
uses: actions/checkout@v4
144+
145+
- name: Set up Python
146+
uses: actions/setup-python@v5
147+
with:
148+
python-version: 3.9
149+
150+
- name: Install Poetry
151+
shell: bash
152+
run: |
153+
pipx install poetry==1.8.5
154+
155+
- name: Install Script Packages with Poetry
156+
shell: bash
157+
run: |
158+
poetry install --all-extras
159+
160+
- name: Run Python script for all files
161+
run: |
162+
make schema-errors

‎Makefile‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,3 +139,10 @@ schema-errors:
139139
poetry run python scripts/validate_schema.py operationoutcome "$$(realpath $$file)"; \
140140
echo -e "$(GREEN)Success!$(RESET)"; \
141141
done
142+
143+
schema-get-questionnaire:
144+
@for file in specification/examples/responses/GET_QuestionnaireResponse/*.yaml; do \
145+
echo "Processing $$file"; \
146+
poetry run python scripts/validate_schema.py questionnaireresponse "$$(realpath $$file)"; \
147+
echo -e "$(GREEN)Success!$(RESET)"; \
148+
done

‎openapitools.json‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)