NPA-4513 Update Sandbox Scenarios

Author: JackPlowman

sandbox/api/app.py

@@ -150,7 +150,7 @@ def post_consent() -> Union[dict, tuple]:
 
         # Invalid access level
         elif patient_identifier == "9000000025":
-            response = generate_response_from_example(POST_CONSENT__INVALID_ACCESS_LEVEL_ERROR, 400)
+            response = generate_response_from_example(POST_CONSENT__INVALID_ACCESS_LEVEL_ERROR, 403)
 
         # Missing required evidence
         elif patient_identifier == "9000000033":

sandbox/api/tests/test_app.py

@@ -201,7 +201,7 @@ def test_get_consent(
             201,
             "https://sandbox.api.service.nhs.uk/validated-relationships/FHIR/R4/Consent/9000000017",
         ),
-        ("9000000000", POST_CONSENT__PERFORMER_IDENTIFIER_ERROR, 400, None),
+        ("9000000000", POST_CONSENT__PERFORMER_IDENTIFIER_ERROR, 422, None),
         ("9000000049", POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR, 409, None),
         ("9000000041", POST_CONSENT__INVALID_PATIENT_AGE_ERROR, 422, None),
         ("9000000033", POST_CONSENT__INVALID_EVIDENCE_ERROR, 422, None),

specification/validated-relationships-service-api.yaml

@@ -507,8 +507,8 @@ paths:
         | --------------------------------------- | ---------------------------------------------------------------------------------------------------------- | --------------------------------------------------------- |
         | Successful parent-child proxy creation  | Valid request with a legal basis of parental responsibility, with performer identifier value of 9000000009 | HTTP Status 201 and OperationOutcome response             |
         | Successful adult-adult proxy creation   | Valid request with legal basis of consent, with performer identifier value of 9000000017                   | HTTP Status 201 and OperationOutcome response             |
-        | Invalid performer NHS number            | Request with invalid NHS number format, with performer identifier value of 9000000000                      | HTTP Status 400 and INVALID_NHS_NUMBER error response     |
-        | Invalid access level                    | Request with undefined access level code, with performer identifier value of 9000000025                    | HTTP Status 400 and INVALID_ACCESS_LEVEL error response   |
+        | Invalid access level                    | Request with undefined access level code, with performer identifier value of 9000000025                    | HTTP Status 403 and INVALID_ACCESS_LEVEL error response   |
+        | Invalid performer NHS number            | Request with invalid NHS number format, with performer identifier value of 9000000000                      | HTTP Status 422 and INVALID_NHS_NUMBER error response     |
         | Missing required evidence               | Request without evidence of responsibility, with performer identifier value of 9000000033                  | HTTP Status 422 and MISSING_EVIDENCE error response       |
         | Patient age validation failure          | Request for child proxy where child is over 16, with performer identifier value of 9000000041              | HTTP Status 422 and INVALID_PATIENT_AGE error response    |
         | Duplicate relationship                  | Request for relationship that already exists, with performer identifier value of 9000000049                | HTTP Status 409 and DUPLICATE_RELATIONSHIP error response |