NPA-4514 Remove Old Test Scenarios

Author: JackPlowman

sandbox/api/app.py

@@ -148,26 +148,12 @@ def post_consent() -> Union[dict, tuple]:
             header = {"location": f"{APP_BASE_PATH}/{patient_identifier}"}
             response = generate_response_from_example(POST_CONSENT__SUCCESS, 201, headers=header)
 
-        # Invalid access level
-        elif patient_identifier == "9000000025":
-            response = generate_response_from_example(POST_CONSENT__INVALID_ACCESS_LEVEL_ERROR, 403)
-
-        # Missing required evidence
-        elif patient_identifier == "9000000033":
-            response = generate_response_from_example(POST_CONSENT__INVALID_EVIDENCE_ERROR, 422)
-
-        # Patient age validation failure
-        elif patient_identifier == "9000000041":
-            response = generate_response_from_example(POST_CONSENT__INVALID_PATIENT_AGE_ERROR, 422)
-
         # Duplicate relationship
         elif patient_identifier == "9000000049":
             response = generate_response_from_example(POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR, 409)
-
         # Invalid performer NHS number
         elif patient_identifier == "9000000000":
             response = generate_response_from_example(POST_CONSENT__PERFORMER_IDENTIFIER_ERROR, 422)
-
         else:
             # Out of scope errors
             raise ValueError("Invalid Request")

sandbox/api/constants.py

@@ -51,9 +51,6 @@
 POST_CONSENT__DIRECTORY = "./api/examples/POST_Consent/"
 POST_CONSENT__SUCCESS = f"{POST_CONSENT__DIRECTORY}success.yaml"
 POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR = f"{POST_CONSENT__DIRECTORY}errors/duplicate_relationship_error.yaml"
-POST_CONSENT__INVALID_ACCESS_LEVEL_ERROR = f"{POST_CONSENT__DIRECTORY}errors/invalid_access_level_error.yaml"
-POST_CONSENT__INVALID_EVIDENCE_ERROR = f"{POST_CONSENT__DIRECTORY}errors/invalid_evidence_error.yaml"
-POST_CONSENT__INVALID_PATIENT_AGE_ERROR = f"{POST_CONSENT__DIRECTORY}errors/invalid_patient_age_error.yaml"
 POST_CONSENT__PERFORMER_IDENTIFIER_ERROR = f"{POST_CONSENT__DIRECTORY}errors/invalid_performer_identifier_error.yaml"
 
 QR_DIRECTORY = "./api/examples/POST_QuestionnaireResponse/"

sandbox/api/tests/test_app.py

@@ -205,7 +205,7 @@ def test_get_consent(
         ("9000000049", POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR, 409, None),
         ("9000000041", POST_CONSENT__INVALID_PATIENT_AGE_ERROR, 422, None),
         ("9000000033", POST_CONSENT__INVALID_EVIDENCE_ERROR, 422, None),
-        ("9000000025", POST_CONSENT__INVALID_ACCESS_LEVEL_ERROR, 403, None),
+
     ],
 )
 @patch(f"{APP_FILE_PATH}.generate_response_from_example")

specification/examples/responses/POST_Consent/errors/invalid_access_level_error.yaml

@@ -507,10 +507,7 @@ paths:
         | --------------------------------------- | ---------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------- |
         | Successful parent-child proxy creation  | Valid request with a legal basis of parental responsibility, with performer identifier value of 9000000009 | HTTP Status 201 and OperationOutcome response               |
         | Successful adult-adult proxy creation   | Valid request with legal basis of consent, with performer identifier value of 9000000017                   | HTTP Status 201 and OperationOutcome response               |
-        | Invalid access level                    | Request with undefined access level code, with performer identifier value of 9000000025                    | HTTP Status 403 and INVALID_ACCESS_LEVEL error response     |
         | Invalid performer NHS number            | Request with invalid NHS number format, with performer identifier value of 9000000000                      | HTTP Status 422 and INVALID_IDENTIFIER_VALUE error response |
-        | Missing required evidence               | Request without evidence of responsibility, with performer identifier value of 9000000033                  | HTTP Status 422 and MISSING_EVIDENCE error response         |
-        | Patient age validation failure          | Request for child proxy where child is over 16, with performer identifier value of 9000000041              | HTTP Status 422 and INVALID_PATIENT_AGE error response      |
         | Duplicate relationship                  | Request for relationship that already exists, with performer identifier value of 9000000049                | HTTP Status 409 and DUPLICATE_RELATIONSHIP error response   |
 
       operationId: create-proxy-role
@@ -577,12 +574,6 @@ paths:
               examples:
                 postConsentInvalidPerformerIdentifier:
                   $ref: "./examples/responses/POST_Consent/errors/invalid_performer_identifier_error.yaml#/PostConsentInvalidPerformerIdentifierError"
-                postConsentInvalidAccessLevel:
-                  $ref: "./examples/responses/POST_Consent/errors/invalid_access_level_error.yaml#/PostConsentInvalidAccessLevelError"
-                postConsentMissingEvidence:
-                  $ref: "./examples/responses/POST_Consent/errors/invalid_evidence_error.yaml#/PostConsentInvalidEvidenceError"
-                postConsentInvalidPatientAge:
-                  $ref: "./examples/responses/POST_Consent/errors/invalid_patient_age_error.yaml#/PostConsentInvalidPatientAgeError"
                 postConsentDuplicateRelationship:
                   $ref: "./examples/responses/POST_Consent/errors/duplicate_relationship_error.yaml#/PostConsentDuplicateRelationshipError"