Skip to content

Undocumented peer dependencies #4

@frankcalise

Description

@frankcalise

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

Hello! Your library looks very interesting. I'm looking to switch from react-native-youtube-iframe, however upon installation I needed (so far) @react-native-community/slider and after prebuilding it wants me to install @react-native-vector-icons/ionicons.

These weren't mentioned in the installation doc, would you like me to update it?

Also, it might be best if we could some how detect if react native vector icons OR expo vector icons (as an Expo project is more likely to have this one perhaps) were to be installed to avoid having duplicate icon libraries.

Library version

0.2.0

Environment info

Expo 53
React Native 0.79.5

Steps to reproduce

  1. yarn add @flixsrota/player
  2. npx expo prebuild --clean
  3. npx expo run:ios
  4. Observe errors about slider, vector icons

Reproducible example repository

https://github.com/NIKHIL0VERMA/flixsrota-player/blob/main/example/package.json

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions