Merge pull request #262 from NLeSC/python_quality_services

update code quality services (for Python)

Author: bouweandela

best_practices/code_quality.md

@@ -1,8 +1,8 @@
 # Code Quality
 
-Ways to improve code quality are in the [Code quality](https://the-turing-way.netlify.app/code_quality/code_quality.html) chapter on the Turing Way.
+Ways to improve code quality are in the [Code quality](https://the-turing-way.netlify.app/reproducible-research/code-quality.html) chapter on the Turing Way.
 
-There are [online software quality improvement tools](https://the-turing-way.netlify.app/code_quality/code_quality.html#Online-services-providing-software-quality-checks) see the [language guides](language_guides/languages_overview.md) for good options per language.
+There are [online software quality improvement tools](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-style.html#online-services-providing-software-quality-checks) see the [language guides](language_guides/languages_overview.md) for good options per language.
 
 ## Editorconfig
 

best_practices/documentation.md

@@ -88,7 +88,7 @@ file describes at least how to perform the following tasks:
 
 * How to [install the dependencies](#documented-development-setup)
 * How to run [(unit) tests](testing.md#unit-tests)
-* What [code style](https://the-turing-way.netlify.app/code_quality/code_quality.html#Code-style) to use
+* What [code style](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-style.html) to use
 * Reference to [code of conduct](#code-of-conduct)
 * When using a [git branching model](version_control.md#choose-one-branching-model), the choice of branching model
 

best_practices/language_guides/python.md

@@ -140,28 +140,13 @@ If this is not possible or does not fit then use one of the generic code coverag
 
 ## Code quality analysis tools and services
 
-Code quality service is explained in the [The Turing Way](https://the-turing-way.netlify.app/code_quality/code_quality.html#Online-services-providing-software-quality-checks).
-There are multiple code quality services available for Python.
-There is not a best one, below is a short list of services with their different strenghts.
+Code quality service is explained in the [The Turing Way](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-style.html#online-services-providing-software-quality-checks).
+There are multiple code quality services available for Python, all of which have their pros and cons.
+See [The Turing Way](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-resources.html) for links to lists of possible services.
+We currently setup [Sonarcloud](https://sonarcloud.io/) by default in our [Python template](https://github.com/NLeSC/python-template).
+To reproduce the Sonarcloud pipeline locally, you can use [SonarLint](https://www.sonarlint.org/) in your IDE.
+If you use another editor, perhaps it is more convenient to pick another service like Codacy or Codecov.
 
-### [Codacy](https://www.codacy.com)
-
-Code quality and coverage grouped by file.
-Can setup goals to improve quality or coverage by file or category.
-For example project see https://www.codacy.com/app/3D-e-Chem/kripodb/dashboard.
-Note that Codacy does not install your depencencies, which prevents it from correctly identifying import errors.
-
-### [Scrutinizer](https://scrutinizer-ci.com/)
-
-Code quality and coverage grouped by class and function.
-For example project see https://scrutinizer-ci.com/g/NLeSC/eEcology-Annotation-WS/
-
-### [Landscape](https://landscape.io)
-
-Dedicated for Python code quality.
-Celery, Django and Flask specific behaviors.
-The Landscape analysis tool called [`prospector`](https://github.com/landscapeio/prospector) can be run locally.
-For example project see https://landscape.io/github/NLeSC/MAGMa
 
 ## Debugging and profiling
 

best_practices/testing.md

@@ -57,7 +57,7 @@ At the Netherlands eScience Center we require minimum of 70% coverage.
 Setting up code coverage for a repository depends on the programming language, see the [language specific guides](language_guides/languages_overview.md) for setup instructions.
 
 The code coverage should be performed when a test suite is run as part of Continuous Integration build job.
-The code coverage results can be published on code coverage and/or [code quality services](https://the-turing-way.netlify.app/code_quality/code_quality.html#Online-services-providing-software-quality-checks).
+The code coverage results can be published on code coverage and/or [code quality services](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-style.html#online-services-providing-software-quality-checks).
 
 ### Code coverage services
 

nlesc_specific/checklist.md

@@ -40,7 +40,7 @@ The [checklist matrix](./checklist_matrix.md) provides an indication of which it
 ## [Code Quality](../best_practices/code_quality.md)
 
 - [use editorconfig](../best_practices/code_quality.md#use-editorconfig)
-- [code style applied in automated way](https://the-turing-way.netlify.app/code_quality/code_quality.html#Automatic-formatting)
+- [code style applied in automated way](https://the-turing-way.netlify.app/reproducible-research/code-quality/code-quality-style.html#automatic-formatting)
 
 ## [Testing](../best_practices/testing.md)