Skip to content

Commit c346164

Browse files
authored
Updated dependency NLog to v5.2.2 (#170)
1 parent d9b390a commit c346164

File tree

3 files changed

+22
-14
lines changed

3 files changed

+22
-14
lines changed

azure-pipelines.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ variables:
1313
Solution: 'src/NLog.MailKit.sln'
1414
BuildPlatform: 'Any CPU'
1515
BuildConfiguration: 'Release'
16-
Version: '5.1.3'
16+
Version: '5.1.0'
1717
FullVersion: '$(Version).$(Build.BuildId)'
1818

1919
steps:

src/NLog.MailKit/MailTarget.cs

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public class MailTarget : TargetWithLayoutHeaderAndFooter
9191
/// Initializes a new instance of the <see cref="MailTarget" /> class.
9292
/// </summary>
9393
/// <remarks>
94-
/// The default value of the layout is: <code>${longdate}|${level:uppercase=true}|${logger}|${message:withexception=true}</code>
94+
/// The default value of the Body-Layout is: <code>${message}${newline}</code>
9595
/// </remarks>
9696
public MailTarget()
9797
{
@@ -102,7 +102,7 @@ public MailTarget()
102102
/// Initializes a new instance of the <see cref="MailTarget" /> class.
103103
/// </summary>
104104
/// <remarks>
105-
/// The default value of the layout is: <code>${longdate}|${level:uppercase=true}|${logger}|${message:withexception=true}</code>
105+
/// The default value of the Body-Layout is: <code>${message}${newline}</code>
106106
/// </remarks>
107107
/// <param name="name">Name of the target.</param>
108108
public MailTarget(string name) : this()
@@ -309,7 +309,7 @@ private void ProcessSingleMailMessage(IEnumerable<AsyncLogEventInfo> events)
309309
{
310310
client.Timeout = RenderLogEvent(Timeout, lastEvent);
311311

312-
var renderedHost = SmtpServer.Render(lastEvent);
312+
var renderedHost = RenderLogEvent(SmtpServer, lastEvent);
313313
if (string.IsNullOrEmpty(renderedHost))
314314
{
315315
throw new NLogRuntimeException(string.Format(RequiredPropertyIsEmptyFormat, nameof(SmtpServer)));
@@ -341,8 +341,8 @@ private void ProcessSingleMailMessage(IEnumerable<AsyncLogEventInfo> events)
341341
var smtpAuthentication = RenderLogEvent(SmtpAuthentication, LogEventInfo.CreateNullEvent());
342342
if (smtpAuthentication == SmtpAuthenticationMode.Basic)
343343
{
344-
var userName = SmtpUserName?.Render(lastEvent);
345-
var password = SmtpPassword?.Render(lastEvent);
344+
var userName = RenderLogEvent(SmtpUserName, lastEvent);
345+
var password = RenderLogEvent(SmtpPassword, lastEvent);
346346

347347
InternalLogger.Debug("Authenticate with username '{0}'", userName);
348348
client.Authenticate(userName, password);
@@ -465,9 +465,9 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
465465

466466
msg.Subject = (RenderLogEvent(Subject, lastEvent) ?? string.Empty).Trim();
467467

468-
if (Priority != null)
468+
var renderedPriority = RenderLogEvent(Priority, lastEvent);
469+
if (!string.IsNullOrEmpty(renderedPriority))
469470
{
470-
var renderedPriority = Priority.Render(lastEvent);
471471
msg.Priority = ParseMessagePriority(renderedPriority);
472472
}
473473

@@ -477,6 +477,10 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
477477
if (html && replaceNewlineWithBrTagInHtml)
478478
{
479479
newBody = newBody?.Replace(Environment.NewLine, "<br/>");
480+
if (newBody?.IndexOf('\n') >= 0)
481+
{
482+
newBody = newBody?.Replace("\n", "<br/>");
483+
}
480484
}
481485

482486
var encoding = RenderLogEvent(Encoding, lastEvent, DefaultEncoding);
@@ -486,16 +490,19 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
486490
ContentType = { Charset = encoding?.WebName }
487491
};
488492

489-
490493
if (MailHeaders?.Count > 0)
491494
{
492495
for (int i = 0; i < MailHeaders.Count; i++)
493496
{
497+
var headerName = MailHeaders[i].Name;
498+
if (string.IsNullOrEmpty(headerName))
499+
continue;
500+
494501
string headerValue = RenderLogEvent(MailHeaders[i].Layout, lastEvent);
495502
if (headerValue is null)
496503
continue;
497504

498-
msg.Headers.Add(MailHeaders[i].Name, headerValue);
505+
msg.Headers.Add(headerName, headerValue);
499506
}
500507
}
501508

src/NLog.MailKit/NLog.MailKit.csproj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFramework>netstandard2.0</TargetFramework>
3+
<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
44
<Authors>Julian Verdurmen</Authors>
55
<Company>NLog</Company>
66
<Description>NLog Mail Target for .NET Core &amp; .NET Standard 2.0+ using MailKit.
@@ -31,7 +31,8 @@ If the mail target was already available on your platform, this package will ove
3131
<PackageReleaseNotes>
3232
- Added support for email headers
3333
- Added target-alias mailkit
34-
- Updated to NLog v5.1.3
34+
- Updated to NLog v5.2.2
35+
- Updated to MailKit v3.3.0
3536

3637
See https://github.com/NLog/NLog.MailKit/releases
3738

@@ -46,11 +47,11 @@ See https://github.com/NLog/NLog.MailKit/releases
4647
<DefineConstants>RELEASE</DefineConstants>
4748
</PropertyGroup>
4849
<ItemGroup>
49-
<PackageReference Include="MailKit" Version="3.2.0" />
50+
<PackageReference Include="MailKit" Version="3.3.0" />
5051
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
5152
</ItemGroup>
5253
<ItemGroup>
53-
<PackageReference Include="NLog" Version="5.1.3" />
54+
<PackageReference Include="NLog" Version="5.2.2" />
5455
</ItemGroup>
5556
<ItemGroup>
5657
<None Include="..\..\README.md">

0 commit comments

Comments
 (0)