download theoryid in setupfit, even in faketheoryid exists

Author: RoyStegeman

n3fit/runcards/examples/Basic_runcard_closure_test.yml

@@ -83,5 +83,6 @@ maxcores: 8
 closuretest:
   filterseed: 3345348918 # Random seed to be used in filtering data partitions
   fakedata: true     # true = to use FAKEPDF to generate pseudo-data
-  fakepdf: NNPDF40_nnlo_as_01180      # Theory input for pseudo-data
+  fakepdf: NNPDF40_nnlo_as_01180      # PDF input for pseudo-data
   fakenoise: true    # true = to add random fluctuations to pseudo-data
+  faketheoryid: 708  # theory input for pseudo-data

n3fit/src/n3fit/scripts/vp_setupfit.py

@@ -37,8 +37,11 @@
 from reportengine import colors
 from validphys.app import App
 from validphys.config import Config, ConfigError, Environment, EnvironmentError_
+from validphys.loader import FallbackLoader
 from validphys.utils import yaml_safe
 
+l = FallbackLoader()
+
 SETUPFIT_FIXED_CONFIG = dict(
     actions_=[
         'datacuts check_t0pdfset',
@@ -146,7 +149,12 @@ def from_yaml(cls, o, *args, **kwargs):
             # Use faketheoryid to create the L0 data to be stored into the filter folder
             # (L1 data is stored if fakedata is True)
             if 'faketheoryid' in closuredict:
-                file_content['theory']['theoryid'] = closuredict['faketheoryid']
+                # make sure theory key exists in SETUPFIT_FIXED_CONFIG
+                SETUPFIT_FIXED_CONFIG.setdefault('theory', {})
+                # overwrite theoryid with the faketheoryid
+                SETUPFIT_FIXED_CONFIG['theory']['theoryid'] = closuredict['faketheoryid']
+                # download theoryid since it will be used in the fit
+                l.check_theoryID(file_content['theory']['theoryid'])
             filter_action = 'datacuts::closuretest::theory::fitting filter'
             check_n3fit_action = 'datacuts::theory::closuretest::fitting n3fit_checks_action'
         else: