Fix convolution checks

Author: Radonirinaunimi

pineappl_py/tests/test_fk_table.py

@@ -122,6 +122,8 @@ def test_fktable_rotations(
         tmp_path,
         fkname: str = "FKTABLE_CMSTTBARTOT8TEV-TOPDIFF8TEVTOT.pineappl.lz4",
     ):
+        expected_results = [3.72524538e04]  # Numbers computed using `v0.8.6`
+
         fk_table = download_objects(f"{fkname}")
         fk = FkTable.read(fk_table)
 
@@ -135,23 +137,20 @@ def test_fktable_rotations(
         fk_pdg_facs = fk.channels_factors()
         np.testing.assert_array_equal(fk_pdg_facs, 1)
 
-        # check that the FK table can be loaded properly
-        path = f"{tmp_path}/rotated_fktable.pineappl.lz4"
-        fk.write_lz4(path)
-        fk_mod = FkTable.read(path)
-
-        # check that the convolutions are the same
+        # check that the convolutions are still the same
         np.testing.assert_allclose(
             fk.convolve(
                 pdg_convs=fk.convolutions,
                 xfxs=[pdf.unpolarized_pdf, pdf.unpolarized_pdf],
             ),
-            fk_mod.convolve(
-                pdg_convs=fk_mod.convolutions,
-                xfxs=[pdf.unpolarized_pdf, pdf.unpolarized_pdf],
-            ),
+            expected_results,
         )
 
+        # check that the FK table can be loaded properly
+        path = f"{tmp_path}/rotated_fktable.pineappl.lz4"
+        fk.write_lz4(path)
+        _ = FkTable.read(path)
+
     def test_unpolarized_convolution(
         self,
         pdf,
@@ -161,7 +160,7 @@ def test_unpolarized_convolution(
         """Check the convolution of an actual FK table that involves two
         symmetrical unpolarized protons:
         """
-        expected_results = [3.72524538e04]
+        expected_results = [3.72524538e04]  # Numbers computed using `v0.8.6`
         fk_table = download_objects(f"{fkname}")
         fk = FkTable.read(fk_table)
 

pineappl_py/tests/test_grid.py

@@ -405,6 +405,15 @@ def test_grid_rotations(
         tmp_path,
         gridname: str = "GRID_DYE906R_D_bin_1.pineappl.lz4",
     ):
+        expected_results = [
+            +3.71019208e4,
+            +3.71019208e4,
+            +2.13727492e4,
+            -1.83941398e3,
+            +3.22728612e3,
+            +5.45646897e4,
+        ]  # Numbers computed using `v0.8.6`
+
         grid = download_objects(f"{gridname}")
         g = Grid.read(grid)
 
@@ -424,25 +433,21 @@ def test_grid_rotations(
         g_facs = g.channels_factors()
         np.testing.assert_array_equal(g_facs, 1)
 
-        # check that the FK table can be loaded properly
-        path = f"{tmp_path}/grid_merged_factors.pineappl.lz4"
-        g.write_lz4(path)
-        g_mod = Grid.read(path)
-
-        # check that the convolutions are the same
+        # check that the convolutions are still the same
         np.testing.assert_allclose(
             g.convolve(
                 pdg_convs=g.convolutions,
                 xfxs=[pdf.polarized_pdf],
                 alphas=pdf.alphasQ,
             ),
-            g_mod.convolve(
-                pdg_convs=g_mod.convolutions,
-                xfxs=[pdf.polarized_pdf],
-                alphas=pdf.alphasQ,
-            ),
+            expected_results,
         )
 
+        # check that the FK table can be loaded properly
+        path = f"{tmp_path}/grid_merged_factors.pineappl.lz4"
+        g.write_lz4(path)
+        _ = Grid.read(path)
+
     def test_unpolarized_convolution(
         self,
         pdf,