Test failures on s390x

[opoplawski]

I'm looking to update the Fedora g2c library package to 2.1.0 but I'm getting the following test failures on s390x:

      Start 25: tst_metacmp
24/42 Test #25: tst_metacmp ......................***Failed    0.00 sec
Testing g2c_metacmp
      Start 26: tst_inq
      Start 27: tst_degrib2_int
26/42 Test #26: tst_inq ..........................***Failed    0.00 sec
Testing g2c inquiry functions.
Testing g2c_inq()/g2c_inq_msg()/g2c_inq_prod() calls...
	testing open of data/gdaswave.t00z.wcoast.0p16.f000.grib2 without an index file...
      Start 28: tst_degrib2_fast
28/42 Test #28: tst_degrib2_fast .................***Failed    0.00 sec
Testing g2c degrib2 function.
Testing g2c_degrib2() on file data/gdaswave.t00z.wcoast.0p16.f000.grib2...
      Start 31: tst_index
30/42 Test #30: tst_degrib2_ftp_all ..............   Passed    0.00 sec
      Start 32: tst_files
31/42 Test #31: tst_index ........................***Failed    0.00 sec
Testing g2c index functions.
Testing g2c_open_index() on file data/gdaswave.t00z.wcoast.0p16.f000.grib2...
      Start 33: tst_g2_testfile
32/42 Test #32: tst_files ........................***Failed    0.00 sec
Testing g2c file functions.
Testing g2c_open() on file data/gdaswave.t00z.wcoast.0p16.f000.grib2 (twice)...ok!
Testing g2c_find_msg2 on file data/gdaswave.t00z.wcoast.0p16.f000.grib2...
      Start 34: tst_aec
33/42 Test #33: tst_g2_testfile ..................***Failed    0.00 sec
Testing with file created in NCEPLIBS-g2.
testing opening of the file...
      Start 37: tst_large_png
37/42 Test #37: tst_large_png ....................***Failed    0.00 sec
Testing dec_png() on large test file...
      Start 42: run_compare_tests.sh
42/42 Test #42: run_compare_tests.sh .............***Failed    0.00 sec
*** Running g2c_convert test
g2c_compare 2.1.0 comparing data/gdaswave.t00z.wcoast.0p16.f000.grib2 and data/gdaswave.t00z.wcoast.0p16.f000.grib2.

This is likely due to the different endianness of s390x. There is not a lot of output from the tests so hard to know what is going on. Can we get more output?

[opoplawski]

I'm also seeing similar failures on 32-bit i686

[edwardhartnett]

Howdy Orion!

Firstly we are up to version 4.1.0, so you might as well be working with the latest version.

But I don't know how to test on machine of different endianness. Does GitHub offer any platform that would help?

[opoplawski]

Actually, looks like you are at version 2.1.0 - I think we both got confused there. Github does not appear to offer any s390x hosts for CI. I can build and run anything on a Fedora s390x machine - so let me know what would be helpful.

[edwardhartnett]

Yes, I meant 2.1.0.

But nonetheless, I cannot hope to get g2 to work on a platform I don't have access to for testing.

Try running one of the failing tests from the command line and see if the output says anything useful.

[opoplawski]

So, with tst_inq it seems like it in trying to seek past the end of the file. strace shows:

write(1, "\ttesting open of data/gdaswave.t"..., 84     testing open of data/gdaswave.t00z.wcoast.0p16.f000.grib2 without an index file...
) = 84
openat(AT_FDCWD, "data/gdaswave.t00z.wcoast.0p16.f000.grib2", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=281650, ...}) = 0
lseek(3, 0, SEEK_SET)                   = 0
read(3, "GRIB\0\0\0\2\0\0\0\0\0\0;\226\0\0\0\25\1\0\7\0\0\2\1\1\7\345\v\36"..., 4096) = 4096
lseek(3, 65515431129088, SEEK_SET)      = -1 EINVAL (Invalid argument)
lseek(3, -4, SEEK_CUR)                  = 4092
exit_group(-54)                         = ?

I enabled some logging:

      Start 26: tst_inq

26: Test command: /builddir/build/BUILD/g2clib-2.1.0-build/NCEPLIBS-g2c-2.1.0/redhat-linux-build/tests/tst_inq
26: Working Directory: /builddir/build/BUILD/g2clib-2.1.0-build/NCEPLIBS-g2c-2.1.0/redhat-linux-build/tests
26: Test timeout computed to be: 1500
26:     log_level changed to 10
26:             g2c_open path data/gdaswave.t00z.wcoast.0p16.f000.grib2 mode 0
26:                     g2c_add_file path data/gdaswave.t00z.wcoast.0p16.f000.grib2 mode 0
26:                             read_metadata g2cid 1
26:                     g2c_seekgb skip 0
26:                             my_msglen 65515431133184
26: Testing g2c inquiry functions.
26: Testing g2c_inq()/g2c_inq_msg()/g2c_inq_prod() calls...
26:     testing open of data/gdaswave.t00z.wcoast.0p16.f000.grib2 without an index file...
26/42 Test #26: tst_inq ..........................***Failed    0.00 sec

[opoplawski]

In g2c_seekmsg (g2cid=1, skip=0, offset=0x3ffffff6d80, msglen=0x3ffffff6d78) at /builddir/build/BUILD/g2clib-2.1.0-build/NCEPLIBS-g2c-2.1.0/src/g2cfile.c:87:

97                      my_msglen = hton64(*(size_t *)&cbuf[k + 8]);
(gdb) print cbuf[k+8]
$6 = 0 '\000'
(gdb) print *(size_t *)&cbuf[k+8]
$9 = 15254
(gdb) print my_msglen
$10 = 65515431133184