Edge issues with hord=6

[wmputman]

Is your feature request related to a problem? Please describe.
When using hord=6 schemes there is a clear and detrimental edge problem with artificial convergence producing unwanted edge precipitation

Describe the solution you'd like
There is a simple code addition to alleviate this problem.

For xtp / xppm:

!WMP
! fix edge issues
if ( (.not.nested) .and. grid_type < 3) then
if( is==1 ) then
smt5(0) = bl(0)*br(0) < 0.
smt5(1) = bl(1)*br(1) < 0.
endif
if( (ie+1)==npx ) then
smt5(npx-1) = bl(npx-1)*br(npx-1) < 0.
smt5(npx ) = bl(npx )*br(npx ) < 0.
endif
endif
!WMP

and for ytp / yppm:

!WMP
! fix edge issues
if ( (.not.nested) .and. grid_type < 3) then
if( is==1 ) then
smt5(0) = bl(0)*br(0) < 0.
smt5(1) = bl(1)*br(1) < 0.
endif
if( (ie+1)==npx ) then
smt5(npx-1) = bl(npx-1)*br(npx-1) < 0.
smt5(npx ) = bl(npx )*br(npx ) < 0.
endif
endif
!WMP

See PPT slides attached.
Putman-FV3-Edge.pptx

[lharris4]

Hi, Bill. Just getting back to this. Could you point to the place in your codes where this is to be added or removed?

Thanks,
Lucas

[JosephMouallem]

Fixed in #364