-
Notifications
You must be signed in to change notification settings - Fork 139
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
During the review process of #330, the following items were noted as follow-up work:
- in
driver/fvGFS/atmosphere.F90, the logic around lines 2152 is redundant - see https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/330/files/85faba53a23060b301c898a438d3df2c44fb14a3#diff-53ee59c906ed74739c938e8c964c9c4fc6b71627e5cd6a5741e2cdacedfc16ab for details - in
driver/fvGFS/atmosphere.F90, remove comment in line 1615 - revisit the files change in PR Branch dev/emc: convert GFS DDTs from blocked data structures to contiguous arrays #330 and remove all unnecessary block loops (
do nb=1,blen ...)
Describe the solution you'd like
See above
Describe alternatives you've considered
Leave things as is - not a good idea, since we will be missing out on expected performance improvements
Additional context
n/a
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request