-
Notifications
You must be signed in to change notification settings - Fork 24
Description
There is a bug in the iceberg code in the file icebergs_framework.F90, in the subroutine offset_berg_dates
This routine tries to see if there are any icebergs which were calved in the future, and if so, it subtracts an offset date.
In order to see if there are future bergs, the code compares the number computed in yearday with the number 367. However, 367 should be 373 (since 12*31+1)=373.
As a result of this bug, there are many icebergs which are given the incorrect start dates even when the code is running well.
This bug should be fixed by either
(i) Changing 367 to 373
(ii) The new version of the code will have unique iceberg id's, so this date offset should be removed completely.
(Interestingly, this bug only applies to icebergs calved after Christmas)