refactor: use new constructor of QuantityFactory (#169)

Prefer the new constructor of `QuantityFactor` over the deprecated
call to `QuantityFactor.from_backend(...)`. This removes a bunch of
deprecation warnings in tests.

Co-authored-by: Roman Cattaneo <1116746+romanc@users.noreply.github.com>

Author: romanc

docs/physics/state.rst

@@ -35,7 +35,7 @@ You can initialize a zero-filled PhysicsState and MicrophysicsState from other P
     ...    tile_rank=communicator.tile.rank,
     ... )
 
-    >>> quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend="numpy")
+    >>> quantity_factory = QuantityFactory(sizer=sizer, backend="numpy")
     >>> physics_state = PhysicsState.init_zeros(
     ...  quantity_factory=quantity_factory, schemes=["GFS_microphysics"]
     ... )

examples/notebooks/functions.py

@@ -268,7 +268,7 @@ def configure_domain(
         tile_rank=communicator.tile.rank,
     )
 
-    quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
+    quantity_factory = QuantityFactory(sizer=sizer, backend=backend)
 
     metric_terms = MetricTerms(
         quantity_factory=quantity_factory,

examples/notebooks/grid_generation.ipynb

@@ -188,7 +188,7 @@
     ")\n",
     "\n",
     "# useful for easily allocating distributed data storages (fields)\n",
-    "quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)"
+    "quantity_factory = QuantityFactory(sizer=sizer, backend=backend)"
    ]
   },
   {

pace/driver.py

@@ -177,7 +177,7 @@ def get_grid(
                 tile_partitioner=communicator.partitioner.tile,
                 tile_rank=communicator.tile.rank,
             )
-            quantity_factory = QuantityFactory.from_backend(
+            quantity_factory = QuantityFactory(
                 sizer, backend=self.stencil_config.compilation_config.backend
             )
 
@@ -207,7 +207,7 @@ def get_driver_state(
                 tile_rank=communicator.tile.rank,
             )
             if quantity_factory is None:
-                quantity_factory = QuantityFactory.from_backend(
+                quantity_factory = QuantityFactory(
                     sizer, backend=self.stencil_config.compilation_config.backend
                 )
             if stencil_factory is None:
@@ -760,7 +760,7 @@ def _setup_factories(
     grid_indexing = GridIndexing.from_sizer_and_communicator(
         sizer=sizer, comm=communicator
     )
-    quantity_factory = QuantityFactory.from_backend(
+    quantity_factory = QuantityFactory(
         sizer, backend=config.stencil_config.compilation_config.backend
     )
     stencil_factory = StencilFactory(

pace/state.py

@@ -91,7 +91,7 @@ def load_state_from_restart(
             tile_partitioner=communicator.partitioner.tile,
             tile_rank=communicator.tile.rank,
         )
-        quantity_factory = QuantityFactory.from_backend(
+        quantity_factory = QuantityFactory(
             sizer, backend=driver_config.stencil_config.compilation_config.backend
         )
 

tests/main/driver/test_diagnostics_config.py

@@ -42,7 +42,7 @@ def test_zselect_raises_error_if_not_3d(tmpdir):
             z_select=[ZSelect(level=0, names=["phis"])],
         )
         result = config.diagnostics_factory(unittest.mock.MagicMock())
-        quantity_factory = QuantityFactory.from_backend(
+        quantity_factory = QuantityFactory(
             sizer=SubtileGridSizer.from_tile_params(
                 nx_tile=12,
                 ny_tile=12,
@@ -63,7 +63,7 @@ def test_zselect_raises_error_if_3rd_dim_not_z(tmpdir):
             z_select=[ZSelect(level=0, names=["foo"])],
         )
         result = config.diagnostics_factory(unittest.mock.MagicMock())
-        quantity_factory = QuantityFactory.from_backend(
+        quantity_factory = QuantityFactory(
             sizer=SubtileGridSizer.from_tile_params(
                 nx_tile=12,
                 ny_tile=12,

tests/main/driver/test_restart_fortran.py

@@ -35,7 +35,7 @@ def test_state_from_fortran_restart():
         tile_rank=0,
     )
 
-    quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend="numpy")
+    quantity_factory = QuantityFactory(sizer=sizer, backend="numpy")
     restart_dir = REPO_ROOT / "tests" / "main" / "data" / "c12_restart"
 
     (

tests/main/driver/test_restart_serial.py

@@ -67,7 +67,7 @@ def test_restart_save_to_disk():
             tile_partitioner=partitioner.tile,
             tile_rank=communicator.tile.rank,
         )
-        quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
+        quantity_factory = QuantityFactory(sizer=sizer, backend=backend)
 
         eta_file = Path(driver_config.grid_config.config.eta_file)
         (

tests/main/fv3core/test_dycore_baroclinic.py

@@ -112,7 +112,7 @@ def setup_dycore(
     grid_indexing = GridIndexing.from_sizer_and_communicator(
         sizer=sizer, comm=communicator
     )
-    quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
+    quantity_factory = QuantityFactory(sizer=sizer, backend=backend)
     eta_file = "NDSL/tests/data/eta/eta79.nc"
     metric_terms = MetricTerms(
         quantity_factory=quantity_factory,

tests/main/fv3core/test_dycore_call.py

@@ -96,7 +96,7 @@ def setup_dycore() -> Tuple[DynamicalCore, DycoreState, Timer]:
     grid_indexing = GridIndexing.from_sizer_and_communicator(
         sizer=sizer, comm=communicator
     )
-    quantity_factory = QuantityFactory.from_backend(sizer=sizer, backend=backend)
+    quantity_factory = QuantityFactory(sizer=sizer, backend=backend)
     eta_file = Path("NDSL/tests/data/eta/eta79.nc")
     metric_terms = MetricTerms(
         quantity_factory=quantity_factory,