fix(api_search): recurse into nested dicts in _extract_name (#265)

Instead of falling back to str() for nested dict sub-values, recurse
via _extract_name to extract a human-readable string from inner keys.

Signed-off-by: Eric Hackathorn <erichackathorn@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Hackshaven

src/zyra/connectors/discovery/api_search.py

@@ -308,9 +308,8 @@ def _extract_name(value: Any) -> str | None:
     - ``str`` → returned as-is.
     - ``dict`` → drills into common label-like keys (``name``, ``title``,
       ``id``, ``path``, ``label``, ``url``, ``href``, ``uri``, ``link``)
-      and returns
-      the first value that is not ``None`` and not the empty string, as a
-      string.
+      and returns the first value that is not ``None`` and not the empty
+      string, as a string.  Nested dicts are handled recursively.
     - Other types → converted via ``str()`` as a last resort.
     - ``None`` → returns ``None``.
     """
@@ -332,7 +331,11 @@ def _extract_name(value: Any) -> str | None:
         ):
             v = value.get(key)
             if v is not None and v != "":
-                return str(v) if not isinstance(v, str) else v
+                if isinstance(v, str):
+                    return v
+                if isinstance(v, dict):
+                    return _extract_name(v)
+                return str(v)
         # No recognizable sub-key; fall through to str()
     return str(value)
 

tests/connectors/test_search_api.py

@@ -416,8 +416,9 @@ def test_extract_name_drills_into_dict():
     # Non-string values in name-like keys should be stringified
     assert _extract_name({"id": 123}) == "123"
     assert _extract_name({"name": 42}) == "42"
-    # Nested dict in a name-like key falls through to str() of sub-value
-    assert _extract_name({"name": {"id": "x"}}) == "{'id': 'x'}"
+    # Nested dict in a name-like key is recursively drilled into
+    assert _extract_name({"name": {"id": "x"}}) == "x"
+    assert _extract_name({"name": {"title": "inner", "id": "y"}}) == "inner"
 
 
 def test_normalize_item_nested_dataset_dict():