-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Description
PR #1741 introduced several issues that affect correctness, stability, and maintainability. These changes were merged without prior discussion, and a basic test run would have exposed some of the failures. The issues are outlined below with links for reference.
Issues Identified
-
Invalid
timeoutargument causing runtime failure
in this change, thetimeoutargument is passed to a function that does not accept it, causing the code to fail at runtime. A simple execution test would have revealed this immediately. -
Overpass API concurrency must remain limited to ~3
In this change, it is critical to keep Overpass API calls limited to about three concurrent requests. Public Overpass servers enforce strict per-client load and rate limits; increasing parallelism leads to throttling and timeouts regardless of available CPUs. This constraint was previously intentional and should not be relaxed. -
Redundant code and unused variable (
tasks_args_list)
In this block, the code is redundant, andtasks_args_listis constructed but never used anywhere in the execution path. -
Removal of bridge filename prefix logic without justification
This block was removed. That logic was responsible for assigning the correct region-based prefixes to bridge files (conus,alaska,guam,samoa). Because it was removed, a new command-line argument was added hereThis additional argument is unnecessary if the original, working prefix logic is retained.
Resolution
All four issues are addressed and corrected in my follow-up PR. This restores the original intended behavior, removes dead code, fixes the runtime error, and re-establishes safe Overpass API usage.