Skip to content

[13pt] Multiple issues introduced in PR 1741 #1755

@AliForghani-NOAA

Description

@AliForghani-NOAA

Description

PR #1741 introduced several issues that affect correctness, stability, and maintainability. These changes were merged without prior discussion, and a basic test run would have exposed some of the failures. The issues are outlined below with links for reference.


Issues Identified

  1. Invalid timeout argument causing runtime failure
    in this change, the timeout argument is passed to a function that does not accept it, causing the code to fail at runtime. A simple execution test would have revealed this immediately.

  2. Overpass API concurrency must remain limited to ~3
    In this change, it is critical to keep Overpass API calls limited to about three concurrent requests. Public Overpass servers enforce strict per-client load and rate limits; increasing parallelism leads to throttling and timeouts regardless of available CPUs. This constraint was previously intentional and should not be relaxed.

  3. Redundant code and unused variable (tasks_args_list)
    In this block, the code is redundant, and tasks_args_list is constructed but never used anywhere in the execution path.

  4. Removal of bridge filename prefix logic without justification
    This block was removed. That logic was responsible for assigning the correct region-based prefixes to bridge files (conus, alaska, guam, samoa). Because it was removed, a new command-line argument was added here

    This additional argument is unnecessary if the original, working prefix logic is retained.


Resolution

All four issues are addressed and corrected in my follow-up PR. This restores the original intended behavior, removes dead code, fixes the runtime error, and re-establishes safe Overpass API usage.

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions