refs

Author: SimonCropp

src/.editorconfig

@@ -11,6 +11,11 @@ indent_style = space
 indent_size = 4
 charset = utf-8
 
+# Redundant accessor body
+resharper_redundant_accessor_body_highlighting = error
+
+# Replace with field keyword
+resharper_replace_with_field_keyword_highlighting = error
 
 # Declare types in namespaces
 dotnet_diagnostic.CA1050.severity = None
@@ -200,6 +205,7 @@ resharper_field_can_be_made_read_only_local_highlighting = none
 resharper_merge_into_logical_pattern_highlighting = warning
 resharper_merge_into_pattern_highlighting = error
 resharper_method_has_async_overload_highlighting = warning
+# because stop rider giving errors before source generators have run
 resharper_partial_type_with_single_part_highlighting = warning
 resharper_redundant_base_qualifier_highlighting = warning
 resharper_redundant_cast_highlighting = error
@@ -316,7 +322,7 @@ ij_xml_space_inside_empty_tag = true
 indent_size = 2
 
 # Verify settings
-[*.{received,verified}.{txt,xml,json,md,sql,csv,html}]
+[*.{received,verified}.{txt,xml,json,md,sql,csv,html,md}]
 charset = "utf-8-bom"
 end_of_line = lf
 indent_size = unset

src/Directory.Packages.props

@@ -4,7 +4,7 @@
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
   </PropertyGroup>
   <ItemGroup>
-    <PackageVersion Include="Argon" Version="0.22.0" />
+    <PackageVersion Include="Argon" Version="0.25.0" />
     <PackageVersion Include="ConfigureAwait.Fody" Version="3.3.2" />
     <PackageVersion Include="Fody" Version="6.8.2" />
     <PackageVersion Include="MarkdownSnippets.MsBuild" Version="27.0.2" />
@@ -17,11 +17,11 @@
     <PackageVersion Include="NServiceBus.Attachments.Sql" Version="15.1.0" />
     <PackageVersion Include="NServiceBus.Attachments.Sql.Raw" Version="15.1.0" />
     <PackageVersion Include="NServiceBus.Newtonsoft.Json" Version="4.0.0" />
-    <PackageVersion Include="NServiceBus.Transport.SqlServer" Version="8.1.5" />
+    <PackageVersion Include="NServiceBus.Transport.SqlServer" Version="8.1.6" />
     <PackageVersion Include="Polyfill" Version="7.4.1" />
     <PackageVersion Include="ProjectDefaults" Version="1.0.144" />
     <PackageVersion Include="Verify.SqlServer" Version="10.1.0" />
-    <PackageVersion Include="Verify.XunitV3" Version="28.1.3" />
+    <PackageVersion Include="Verify.XunitV3" Version="28.3.1" />
     <PackageVersion Include="xunit.v3" Version="0.6.0-pre.7" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.0.0-pre.49" />
   </ItemGroup>

src/SqlServer.Native/DelayedQ/IncomingDelayedMessage.cs

@@ -10,27 +10,23 @@ public class IncomingDelayedMessage :
     Func<ValueTask>[] cleanups;
     bool disposed;
     volatile int disposeSignaled;
-    long rowVersion;
-    DateTime? due;
-    string headers;
-    Stream? body;
 
     public IncomingDelayedMessage(long rowVersion, DateTime? due, string headers, Stream? body, Func<ValueTask>[] cleanups)
     {
         Guard.AgainstNegativeAndZero(rowVersion);
         this.cleanups = cleanups;
-        this.rowVersion = rowVersion;
-        this.due = due;
-        this.headers = headers;
-        this.body = body;
+        RowVersion = rowVersion;
+        Due = due;
+        Headers = headers;
+        Body = body;
     }
 
     public long RowVersion
     {
         get
         {
             ThrowIfDisposed();
-            return rowVersion;
+            return field;
         }
     }
 
@@ -39,7 +35,7 @@ public DateTime? Due
         get
         {
             ThrowIfDisposed();
-            return due;
+            return field;
         }
     }
 
@@ -48,7 +44,7 @@ public string Headers
         get
         {
             ThrowIfDisposed();
-            return headers;
+            return field;
         }
     }
 
@@ -57,7 +53,7 @@ public Stream? Body
         get
         {
             ThrowIfDisposed();
-            return body;
+            return field;
         }
     }
 

src/SqlServer.Native/MainQ/IncomingMessage.cs

@@ -10,29 +10,24 @@ public class IncomingMessage :
     Func<ValueTask>[] cleanups;
     bool disposed;
     volatile int disposeSignaled;
-    Guid id;
-    long rowVersion;
-    DateTime? expires;
-    string headers;
-    Stream? body;
 
     public IncomingMessage(Guid id, long rowVersion, DateTime? expires, string headers, Stream? body, Func<ValueTask>[] cleanups)
     {
         Guard.AgainstNegativeAndZero(rowVersion);
         this.cleanups = cleanups;
-        this.id = id;
-        this.rowVersion = rowVersion;
-        this.expires = expires;
-        this.headers = headers;
-        this.body = body;
+        Id = id;
+        RowVersion = rowVersion;
+        Expires = expires;
+        Headers = headers;
+        Body = body;
     }
 
     public Guid Id
     {
         get
         {
             ThrowIfDisposed();
-            return id;
+            return field;
         }
     }
 
@@ -41,7 +36,7 @@ public long RowVersion
         get
         {
             ThrowIfDisposed();
-            return rowVersion;
+            return field;
         }
     }
 
@@ -50,7 +45,7 @@ public DateTime? Expires
         get
         {
             ThrowIfDisposed();
-            return expires;
+            return field;
         }
     }
 
@@ -59,7 +54,7 @@ public string Headers
         get
         {
             ThrowIfDisposed();
-            return headers;
+            return field;
         }
     }
 
@@ -68,7 +63,7 @@ public Stream? Body
         get
         {
             ThrowIfDisposed();
-            return body;
+            return field;
         }
     }