Release/1.19 (#1027)

* update readme about Shibboleth. #517

* PR comments changes. #517

* Update README.md

updated typo. #517

* Refactor GrantPermissions front-end and Add contact attribute to grant admins (#982)

* Add contact to grant_permission, grant

* Add :contact trait to grant permission factory

* Add contact info to Grant show page

* Include contacts in Grant find

* Move role descriptions to select options

* Add :contact to permitted params

* Tweaks to grant permission form display

* Include contact info on submission page

* Update to latest version of turbo-rails

* Move On/Off boolean string translations to I18n, add Yes/No translation

* Make grant permission editing inline via turbo

* continue Make grant permission editing inline via turbo

* Tweak css on contact card

* Add tom-select for type to select

* Import, override tom-select css

* Add tom-select stimulus controller

* Switch to tom-select in new permission form

* Use turbo for all grant permission actions

* Task/fix permission turbo actions (#991)

* Use turbo update to clear the new_permission frame

* Add new permission alphabetically based on last name

* CSS fixes for proper row striping on turbo updates

* Task/remove decorators (#993)

* Remove empty, auto-generated decorators and specs

* Remove all decorators and related specs

* Add helper to get a CSS class based on grant name length

* Remove all things decorator from index

* Put all mailers in their own app/views directory (#997)

* Task/searchable homepage (#995)

* Use stimulus for filtering open grants on homepage 

* Add basic filtering specs

* Quick fix for datepicker error in Firefox (#996)

* Task/add submission award tracking (#1002)

* Fix typo in partial name

* Make a generic stylesheet for tables containing turbo_streams

* Update permission table to use turbo-table stylesheet

* User turbo-table stylesheet and  minimize role-related calls in Submissions index

* Update Submissions index spec to account for turbo-table styles

* WIP: add awarded to submission, use in submissions index page

* WIP: Add optional awarded column to excel view

* WIP: update turbo-rails, hotwire

* Add system specs for awarding submission, clean up or clarify other specs

* Move submission row to partial, fix css striping

* Use shared tests for roles that can un-/award

* WIP: include RecordIdentifier in rails_helper to use dom_id method in system specs

* Use turbo-table style, include award checkbox/form for appropriate admins

* Add specs to confirm who can view awarded form

* Misc partial cleanup, add notice to grant admins about who can view award form/column

* Move export to dedicated controller, limit exported file name length

* Add sorts on Award columns (#1004)

* Update version number and release notes (#1007)

* platform and nokogiri updates (#1011)

* Update to rails 6.1.7 (#1012)

* Task/example file and readme edits (#1013)

* Remove attribute-map.yml from symlinked file list

* Update rails version, clarify text, minor formatting

* task/disable review form edits after completed reviews (#1015)

* Disallow criteria update when grant has completed reviews

* Clarify disabled/editable form status variable name

* Misc formatting, typo correction, and spec improvement

* Task/fix review criteria show alignment (#1018)

* Add shared partial to display review scores/comments on submission admin/panel pages

* Add No Score abbreviation tag helper

* Use new review score/comment partial in admin submission review index pages

* Tweak line-height css in table headers

* Task/fix reviews pdf layout (#1020)

* Fix grid layout problem in PDFs

* Pluralize Applicant text as needed

* Add applicant to submissions created in spec

* Pause for page generation to fix periodically broken specs

* Task/pdf css layout issues (#1021)

* Fix PDF CSS layout (again)

* Add pluralizer helper for Applicant label

* Fix/refactor intermittently failing specs

* Task/add submission state enum (#1024)

* WIP: add migration

* WIP: add review_states to model

* WIP: add state traits to review factory

* WIP: update specs

* WIP: Add state to review controller and form submit button

* WIP: update legacy `is_complete?` method to use enum

* WIP: limit submission score calculations to submitted reviews

* WIP: Add translation for review states

* WIP: include 'draft' status in messages related to reviews

* WIP: Add save draft button to review form

* WIP: add required_criteria scope

* WIP: add helper for review scores to appropriately display scores in index views.

* Fix scores field_with_error issue, move score clear js to stimulus, fix draft/submission error aggregation/display

* Add comments to view partials to clarify behavior

* Formatting fixes

* Fix error enumeration deprecation warning

* Only include scores from submitted reviews on admin grant/submission/reviews display

* Only include score/comment for submitted reviews in xlsx file

* WIP: misc clarification, formatting, typo fixes

* Update version and release notes

* Fix duplicate errors/criteria on assigned->submitted review. Misc spec fixes

* Add i18n entries for score labels

* Add method to remove redundant error on parent in favor of individual criteria_review errors

---------

Co-authored-by: mattbaumann1 <mattbaumann1@users.noreply.github.com>
Co-authored-by: Matthew Baumann <matthew.baumann@northwestern.edu>

Author: jseraf

Gemfile

@@ -4,7 +4,7 @@ source 'https://rubygems.org'
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gem 'pg'
-gem 'rails', '6.1.5'
+gem 'rails', '6.1.7.6'
 
 # Use SCSS for stylesheets
 gem 'sass-rails', '>= 5'

Gemfile.lock

@@ -18,64 +18,64 @@ GIT
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (6.1.5)
-      actionpack (= 6.1.5)
-      activesupport (= 6.1.5)
+    actioncable (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailbox (6.1.5)
-      actionpack (= 6.1.5)
-      activejob (= 6.1.5)
-      activerecord (= 6.1.5)
-      activestorage (= 6.1.5)
-      activesupport (= 6.1.5)
+    actionmailbox (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      activejob (= 6.1.7.6)
+      activerecord (= 6.1.7.6)
+      activestorage (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       mail (>= 2.7.1)
-    actionmailer (6.1.5)
-      actionpack (= 6.1.5)
-      actionview (= 6.1.5)
-      activejob (= 6.1.5)
-      activesupport (= 6.1.5)
+    actionmailer (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      actionview (= 6.1.7.6)
+      activejob (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (6.1.5)
-      actionview (= 6.1.5)
-      activesupport (= 6.1.5)
+    actionpack (6.1.7.6)
+      actionview (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       rack (~> 2.0, >= 2.0.9)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actiontext (6.1.5)
-      actionpack (= 6.1.5)
-      activerecord (= 6.1.5)
-      activestorage (= 6.1.5)
-      activesupport (= 6.1.5)
+    actiontext (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      activerecord (= 6.1.7.6)
+      activestorage (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       nokogiri (>= 1.8.5)
-    actionview (6.1.5)
-      activesupport (= 6.1.5)
+    actionview (6.1.7.6)
+      activesupport (= 6.1.7.6)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activejob (6.1.5)
-      activesupport (= 6.1.5)
+    activejob (6.1.7.6)
+      activesupport (= 6.1.7.6)
       globalid (>= 0.3.6)
-    activemodel (6.1.5)
-      activesupport (= 6.1.5)
+    activemodel (6.1.7.6)
+      activesupport (= 6.1.7.6)
     activemodel-serializers-xml (1.0.2)
       activemodel (> 5.x)
       activesupport (> 5.x)
       builder (~> 3.1)
-    activerecord (6.1.5)
-      activemodel (= 6.1.5)
-      activesupport (= 6.1.5)
-    activestorage (6.1.5)
-      actionpack (= 6.1.5)
-      activejob (= 6.1.5)
-      activerecord (= 6.1.5)
-      activesupport (= 6.1.5)
+    activerecord (6.1.7.6)
+      activemodel (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
+    activestorage (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      activejob (= 6.1.7.6)
+      activerecord (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       marcel (~> 1.0)
       mini_mime (>= 1.1.0)
-    activesupport (6.1.5)
+    activesupport (6.1.7.6)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -166,6 +166,7 @@ GEM
     coderay (1.1.3)
     concurrent-ruby (1.2.2)
     crass (1.0.6)
+    date (3.3.3)
     debug_inspector (1.1.0)
     devise (4.8.1)
       bcrypt (~> 3.0)
@@ -229,7 +230,7 @@ GEM
       nokogiri (>= 1.6.0)
       ruby_parser (~> 3.5)
     htmlentities (4.3.4)
-    i18n (1.12.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     i18n-debug (1.2.0)
       i18n (< 2)
@@ -248,25 +249,39 @@ GEM
     listen (3.5.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    loofah (2.19.1)
+    loofah (2.21.3)
       crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    mail (2.7.1)
+      nokogiri (>= 1.12.0)
+    mail (2.8.1)
       mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
     marcel (1.0.2)
     matrix (0.4.2)
     method_source (1.0.0)
-    mini_mime (1.1.2)
-    minitest (5.18.0)
+    mini_mime (1.1.5)
+    minitest (5.19.0)
     msgpack (1.5.1)
     nested_form (0.3.2)
+    net-imap (0.3.7)
+      date
+      net-protocol
+    net-pop (0.1.2)
+      net-protocol
+    net-protocol (0.2.1)
+      timeout
     net-scp (3.0.0)
       net-ssh (>= 2.6.5, < 7.0.0)
+    net-smtp (0.3.3)
+      net-protocol
     net-ssh (6.1.0)
-    nio4r (2.5.8)
-    nokogiri (1.14.2-x86_64-darwin)
+    nio4r (2.5.9)
+    nokogiri (1.15.4-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.14.2-x86_64-linux)
+    nokogiri (1.15.4-x86_64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.15.4-x86_64-linux)
       racc (~> 1.4)
     orm_adapter (0.5.0)
     pagy (4.10.2)
@@ -284,37 +299,39 @@ GEM
       activesupport (>= 3.0.0)
     pundit-matchers (1.6.0)
       rspec-rails (>= 3.0.0)
-    racc (1.6.2)
-    rack (2.2.6.4)
+    racc (1.7.1)
+    rack (2.2.8)
     rack-test (2.1.0)
       rack (>= 1.3)
-    rails (6.1.5)
-      actioncable (= 6.1.5)
-      actionmailbox (= 6.1.5)
-      actionmailer (= 6.1.5)
-      actionpack (= 6.1.5)
-      actiontext (= 6.1.5)
-      actionview (= 6.1.5)
-      activejob (= 6.1.5)
-      activemodel (= 6.1.5)
-      activerecord (= 6.1.5)
-      activestorage (= 6.1.5)
-      activesupport (= 6.1.5)
+    rails (6.1.7.6)
+      actioncable (= 6.1.7.6)
+      actionmailbox (= 6.1.7.6)
+      actionmailer (= 6.1.7.6)
+      actionpack (= 6.1.7.6)
+      actiontext (= 6.1.7.6)
+      actionview (= 6.1.7.6)
+      activejob (= 6.1.7.6)
+      activemodel (= 6.1.7.6)
+      activerecord (= 6.1.7.6)
+      activestorage (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       bundler (>= 1.15.0)
-      railties (= 6.1.5)
+      railties (= 6.1.7.6)
       sprockets-rails (>= 2.0.0)
     rails-controller-testing (1.0.5)
       actionpack (>= 5.0.1.rc1)
       actionview (>= 5.0.1.rc1)
       activesupport (>= 5.0.1.rc1)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
+    rails-dom-testing (2.2.0)
+      activesupport (>= 5.0.0)
+      minitest
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.5.0)
-      loofah (~> 2.19, >= 2.19.1)
-    railties (6.1.5)
-      actionpack (= 6.1.5)
-      activesupport (= 6.1.5)
+    rails-html-sanitizer (1.6.0)
+      loofah (~> 2.21)
+      nokogiri (~> 1.14)
+    railties (6.1.7.6)
+      actionpack (= 6.1.7.6)
+      activesupport (= 6.1.7.6)
       method_source
       rake (>= 12.2)
       thor (~> 1.0)
@@ -403,9 +420,9 @@ GEM
     spring-watcher-listen (2.0.1)
       listen (>= 2.7, < 4.0)
       spring (>= 1.2, < 3.0)
-    sprockets (4.1.1)
+    sprockets (4.2.0)
       concurrent-ruby (~> 1.0)
-      rack (> 1, < 3)
+      rack (>= 2.2.4, < 4)
     sprockets-es6 (0.9.2)
       babel-source (>= 5.8.11)
       babel-transpiler
@@ -422,9 +439,10 @@ GEM
     temple (0.8.2)
     terser (1.1.11)
       execjs (>= 0.3.0, < 3)
-    thor (1.2.1)
+    thor (1.2.2)
     tilt (2.0.10)
     timeliness (0.4.4)
+    timeout (0.4.0)
     trix (0.10.1)
       rails
     turbo-rails (1.4.0)
@@ -445,17 +463,18 @@ GEM
       bindex (>= 0.4.0)
       railties (>= 6.0.0)
     webrick (1.7.0)
-    websocket-driver (0.7.5)
+    websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
     wicked_pdf (2.1.0)
       activesupport
     wkhtmltopdf-binary (0.12.6.5)
     xpath (3.2.0)
       nokogiri (~> 1.8)
-    zeitwerk (2.6.7)
+    zeitwerk (2.6.11)
 
 PLATFORMS
+  arm64-darwin-22
   x86_64-darwin-18
   x86_64-darwin-20
   x86_64-linux
@@ -506,7 +525,7 @@ DEPENDENCIES
   puma (~> 4.3.12)
   pundit
   pundit-matchers (~> 1.6.0)
-  rails (= 6.1.5)
+  rails (= 6.1.7.6)
   rails-controller-testing
   ransack!
   redis (~> 4.0)

README.md

@@ -14,14 +14,14 @@ The following are required to install competitions:
   * Mailcatcher(https://mailcatcher.me) is used in the development environment for emails.
   * Postgres database
   * RVM installed on the server
-  # Yarn installed on the server
+  * Yarn installed on the server
   * Capistrano for deployment
 
 
 # Compatibility
 
   * Ruby:   3.0.2
-  * Rails:  6.1.4
+  * Rails:  6.1.7
 
 
 # Shibboleth IDP
@@ -35,8 +35,6 @@ The following are required to install competitions:
 
 # Installation
 
-
-
 Configure the following files with your instance's attributes and store the files on the server.
 
 ```
@@ -57,10 +55,10 @@ A default [\_settings.scss file](https://get.foundation/sites/docs/sass.html#the
 ### config/competitions_config.yml
 The application's configuration has been consolidated into this file. Here you will configure your instance's values for your mailers, saml authentication, and application variables. Keys, passwords, and secrets will be stored in /config/secrets.yml
 
-Further information on the configurations associated with the [devise_saml_authenticatable gem](https://github.com/apokalipto/devise_saml_authenticatable).
+Also see further information regarding [devise_saml_authenticatable gem](https://github.com/apokalipto/devise_saml_authenticatable) configurations.
 
 ### config/database.yml
-You will need to configure your database connection. For more details please see the rails docs (https://guides.rubyonrails.org/v6.0.3.4/configuring.html#configuring-a-database).
+You will need to configure your database connection. For more details please see [the rails docs](https://guides.rubyonrails.org/v6.1.7.6/configuring.html#configuring-a-database).
 ```
 development:
   adapter: # postgresql
@@ -72,9 +70,9 @@ development:
 
 ### config/deploy_config.yml
 
-Here you will find instance specific values for Capistrano deployment of the application (https://github.com/capistrano/rails).
+Here you will find instance specific values for [Capistrano deployment](https://github.com/capistrano/rails) of the application.
 
-If you are symlinking your instance's configuration files on your deployment server, these should be included under the linked_files in config/deploy_config.yml.
+Any symlinked configuration files on your instance's deployment server should be included under the `linked_files` in the config/deploy_config.yml.
 
 ### config/storage.yml
 You will need to configure your instance's storage. The configurations for local or AWS storage are included. It is possible to use other services with further changes.
@@ -105,7 +103,7 @@ The included staging and production environment files require the following to b
   * time_zone
 
 ### config/secrets.yml
-Keys, passwords, secrets, and other sensitive information in a secure file.
+Keep keys, passwords, secrets, and other sensitive information in this secure file.
 
 You could use config/credentials.yml for this purpose also.
 https://guides.rubyonrails.org/security.html#environmental-security

app/assets/stylesheets/app.scss

@@ -181,6 +181,7 @@ th,
   background-color: $table-head-background;
   font-size: .85em;
   font-weight: bold;
+  line-height: 1.25em;
   text-align: left;
   padding: .25em 0;
   vertical-align: bottom;