Skip to content

Commit df5a1c9

Browse files
author
Andrés González
committed
Fix button focusable area for accessibility, and slightly reduce positioning complexity
1 parent d995649 commit df5a1c9

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

src/js/slider/SlideNav.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class SlideNav {
114114
this._el.title = DOM.create("div", "tl-slidenav-title", this._el.content_container);
115115
this._el.description = DOM.create("div", "tl-slidenav-description", this._el.content_container);
116116

117-
this._el.icon.innerHTML = " "
117+
// this._el.icon.innerHTML = " "
118118

119119
this._update();
120120
}

src/less/slider/TL.SlideNav.less

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
.tl-slidenav-content-container {
2222
width:@width-slide-nav;
23-
position:absolute;
2423
}
2524
.tl-slidenav-title, .tl-slidenav-description {
2625
//width:100%;
@@ -103,7 +102,7 @@
103102
.tl-slidenav-next {
104103
text-align: right;
105104
margin-right:@margin-slide-nav;
106-
right: @width-slide-nav;
105+
right: 0;
107106
.tl-slidenav-title, .tl-slidenav-description {
108107
margin-left:20px;
109108
}
@@ -116,6 +115,7 @@
116115
}
117116
.tl-slidenav-previous {
118117
text-align: left;
118+
left: 0;
119119
margin-left:@margin-slide-nav;
120120
.tl-slidenav-icon {
121121
margin-left: 0px;
@@ -128,13 +128,9 @@
128128
// Fixes usage of browsers default setting of `direction: rtl`
129129
[dir="rtl"] {
130130
.tl-slidenav-previous {
131-
left: @width-slide-nav;
132-
// due to the &nbsp, we need to tweak this margin
133-
margin-left: -(@margin-slide-nav/2);
131+
direction: ltr;
134132
}
135133
.tl-slidenav-next {
136-
right: @margin-slide-nav;
137-
margin-right: 0;
138134
&:hover .tl-slidenav-icon {
139135
margin-right: -4px;
140136
}
@@ -178,7 +174,6 @@
178174
}
179175
.tl-skinny {
180176
.tl-slidenav-next {
181-
right: 32px;
182177
.tl-slidenav-icon {
183178
margin-left:32 - 24px;
184179
}

0 commit comments

Comments
 (0)