Skip to content

Commit 0de5b4e

Browse files
committed
updates to README and add back smoke test
1 parent 2e5b79e commit 0de5b4e

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

.github/workflows/debian-packages.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,8 @@ jobs:
239239
240240
echo "Testing r2s_gw_dashboard with debian-installed greenwave_monitor..."
241241
242-
# Start monitor node in background
243-
ros2 run greenwave_monitor greenwave_monitor > /dev/null 2>&1 & echo $! > /tmp/gwm_r2s.pid
244-
sleep 3
245-
246242
# Test r2s_gw dashboard with proper terminal
243+
# The dashboard script automatically starts the monitor node
247244
set +e
248245
TERM=linux timeout 10s script -qfec 'ros2 run r2s_gw r2s_gw_dashboard' /dev/null <<< $'q'
249246
EXIT_CODE=$?
@@ -253,16 +250,10 @@ jobs:
253250
echo "✓ r2s_gw_dashboard exited (code: $EXIT_CODE)"
254251
elif [ $EXIT_CODE -eq 124 ]; then
255252
echo "✗ r2s_gw_dashboard timed out"
256-
kill -9 "$(cat /tmp/gwm_r2s.pid)" 2>/dev/null || true
257253
exit 1
258254
else
259255
echo "✓ r2s_gw_dashboard exited with code: $EXIT_CODE (acceptable)"
260256
fi
261-
262-
# Cleanup
263-
kill -INT "$(cat /tmp/gwm_r2s.pid)" 2>/dev/null || true
264-
sleep 1
265-
kill -9 "$(cat /tmp/gwm_r2s.pid)" 2>/dev/null || true
266257
shell: bash
267258

268259
- name: Test greenwave_monitor execution

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ ros2 run greenwave_monitor ncurses_dashboard --demo
7171

7272
### Rich TUI (r2s integration) - Optional
7373

74-
For users who want a more feature-rich terminal interface, **r2s_gw** is available as a separate package. This is a fork of [r2s](https://github.com/mjcarroll/r2s) designed to integrate with Greenwave Monitor.
74+
For users who want an advanced, feature-rich terminal interface, **r2s_gw** is available as a separate package. Built on the excellent [r2s](https://github.com/mjcarroll/r2s) TUI framework and powered by [Textual](https://github.com/textualize/textual/), r2s_gw provides a beautiful, modern interface with enhanced navigation and visualization capabilities.
7575

76-
**Note:** The r2s integration requires additional dependencies (specifically the `textual` Python package) and can slow down when monitoring many topics. For large deployments or minimal dependencies, we recommend using the ncurses dashboard above.
76+
**r2s_gw** is perfect for interactive development and debugging sessions. For production deployments with many topics or minimal dependency requirements, the lightweight ncurses dashboard above is recommended.
7777

7878
To use r2s_gw:
7979

0 commit comments

Comments
 (0)