Skip to content

Commit 3828a36

Browse files
committed
use ros-core images to hopefully align with buildfarm
1 parent 3bec990 commit 3828a36

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

.github/workflows/debian-packages.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
runs-on: ubuntu-latest
6060
needs: [determine-distros]
6161
container:
62-
image: ros:${{ matrix.ros_distro }}-ros-base-${{ matrix.ubuntu_distro }}
62+
image: ros:${{ matrix.ros_distro }}-ros-core-${{ matrix.ubuntu_distro }}
6363
credentials:
6464
username: ${{ secrets.DOCKERHUB_USERNAME }}
6565
password: ${{ secrets.DOCKERHUB_TOKEN }}
@@ -102,7 +102,7 @@ jobs:
102102
runs-on: ubuntu-latest
103103
needs: [determine-distros, generate-debian]
104104
container:
105-
image: ros:${{ matrix.ros_distro }}-ros-base-${{ matrix.ubuntu_distro }}
105+
image: ros:${{ matrix.ros_distro }}-ros-core-${{ matrix.ubuntu_distro }}
106106
credentials:
107107
username: ${{ secrets.DOCKERHUB_USERNAME }}
108108
password: ${{ secrets.DOCKERHUB_TOKEN }}

.github/workflows/ros-tests.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
name: Test ROS2 ${{ matrix.ros_distro }}
3131
runs-on: ubuntu-latest
3232
container:
33-
image: ros:${{ matrix.ros_distro }}-ros-base-${{ matrix.ubuntu_distro }}
33+
image: ros:${{ matrix.ros_distro }}-ros-core-${{ matrix.ubuntu_distro }}
3434
credentials:
3535
username: ${{ secrets.DOCKERHUB_USERNAME }}
3636
password: ${{ secrets.DOCKERHUB_TOKEN }}
@@ -54,10 +54,14 @@ jobs:
5454
- name: Checkout code
5555
uses: actions/checkout@v4
5656

57-
- name: Setup ROS environment
57+
- name: Setup tools and rosdep
5858
run: |
5959
source /opt/ros/${{ matrix.ros_distro }}/setup.bash
60-
apt-get update -qq && apt-get install -y build-essential python3-pip
60+
apt-get update -qq
61+
apt-get install -y python3-rosdep python3-colcon-common-extensions build-essential cmake git python3-pip
62+
rosdep init || true
63+
rosdep update
64+
rosdep install --from-paths . --rosdistro ${{ matrix.ros_distro }} --ignore-src -r -y
6165
shell: bash
6266

6367
- name: Install Python dependencies

greenwave_monitor/package.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<author>Sean Gillen/[email protected], Ann Li/[email protected]></author>
2929

3030
<buildtool_depend>ament_cmake</buildtool_depend>
31-
<buildtool_depend>ament_cmake_auto</buildtool_depend>
3231
<buildtool_depend>ament_cmake_python</buildtool_depend>
3332

3433
<depend>rclcpp</depend>

scripts/build_debian_packages.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ if [ -f "requirements.txt" ]; then
108108
fi
109109
fi
110110

111+
# Resolve system dependencies with rosdep (before build)
112+
echo "Resolving dependencies with rosdep..."
113+
rosdep init 2>/dev/null || sudo rosdep init 2>/dev/null || true
114+
rosdep update --include-eol-distros
115+
rosdep install --from-paths . --rosdistro "$ROS_DISTRO" --ignore-src -r -y
116+
111117
# Build workspace first
112118
echo "Building workspace..."
113119
colcon build --packages-up-to r2s_gw

0 commit comments

Comments
 (0)