Skip to content

Commit 98ff8d9

Browse files
Merge pull request #52 from NVIDIA-ISAAC-ROS/release-3.2
Improve unit test robustness
2 parents 9173278 + 735b8e7 commit 98ff8d9

File tree

4 files changed

+13
-1
lines changed

4 files changed

+13
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ NVIDIA Isaac Transport for ROS package for hardware-acceleration friendly moveme
66

77
## Overview
88

9-
[Isaac ROS NITROS](https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nitros) contains NVIDIA’s implementation
9+
Isaac ROS NITROS contains NVIDIA’s implementation
1010
of type adaptation and negotiation in ROS 2. To learn more about NITROS, see [here](https://nvidia-isaac-ros.github.io/concepts/nitros/index.html).
1111

1212
Isaac ROS NITROS is composed of a number of individual packages, each with either a functional or structural purpose:

isaac_ros_nitros_topic_tools/test/isaac_ros_nitros_topic_tools_camera_drop_node_mode_0_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,10 @@ def test_drop_node(self) -> None:
105105

106106
# Publish TOTAL_COUNT number of messages
107107
counter = 0
108+
# This test requires deterministic communication between the test node
109+
# and the NitrosCameraDropNode. A 1-second delay ensures the NitrosCameraDropNode
110+
# has fully started, preventing message drops/flaky tests.
111+
time.sleep(1.0)
108112
while counter < TOTAL_COUNT:
109113
header = self.node.get_clock().now().to_msg()
110114
image_msg.header.stamp = header

isaac_ros_nitros_topic_tools/test/isaac_ros_nitros_topic_tools_camera_drop_node_mode_1_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,10 @@ def test_drop_node(self) -> None:
119119

120120
# Publish TOTAL_COUNT number of messages
121121
counter = 0
122+
# This test requires deterministic communication between the test node
123+
# and the NitrosCameraDropNode. A 1-second delay ensures the NitrosCameraDropNode
124+
# has fully started, preventing message drops/flaky tests.
125+
time.sleep(1.0)
122126
while counter < TOTAL_COUNT:
123127
header = self.node.get_clock().now().to_msg()
124128
image_msg_1.header.stamp = header

isaac_ros_nitros_topic_tools/test/isaac_ros_nitros_topic_tools_camera_drop_node_mode_2_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,10 @@ def test_drop_node(self) -> None:
110110

111111
# Publish TOTAL_COUNT number of messages
112112
counter = 0
113+
# This test requires deterministic communication between the test node
114+
# and the NitrosCameraDropNode. A 1-second delay ensures the NitrosCameraDropNode
115+
# has fully started, preventing message drops/flaky tests.
116+
time.sleep(1.0)
113117
while counter < TOTAL_COUNT:
114118
header = self.node.get_clock().now().to_msg()
115119
image_msg.header.stamp = header

0 commit comments

Comments
 (0)