Skip to content

Commit cb00eb3

Browse files
Merge pull request #22 from NVIDIA-ISAAC-ROS/release-3.2
Fix boolean parameter being incorrectly parsed as a string
2 parents f03bba7 + e28f4f8 commit cb00eb3

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

nova_carter_bringup/launch/include/navigation_include.launch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def generate_launch_description() -> LaunchDescription:
271271
'vslam_publish_map_to_odom_tf': lu.is_false(enable_lidar_localization),
272272
'nvblox_global_frame': args.global_frame,
273273
'vslam_image_qos': args.vslam_image_qos,
274-
'invert_odom_to_base_tf': is_sim,
274+
'invert_odom_to_base_tf': lu.is_true(is_sim), #Gets the boolean value
275275
'disable_cuvslam': disable_cuvslam,
276276
'disable_nvblox': lu.is_false(args.enable_nvblox_costmap),
277277
'is_sim': is_sim,

nova_carter_bringup/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
44
<name>nova_carter_bringup</name>
5-
<version>3.2.10</version>
5+
<version>3.2.13</version>
66
<description>
77
Launch files to run isaac ros apps on the Nova Carter robot.
88
</description>

nova_carter_bringup/test/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,14 @@ get_dummy_bag_path(DUMMY_BAG_PATH)
3939

4040
add_graph_startup_test(multi_cam_perceptor_dry_run
4141
launch/perceptor.launch.py
42+
DONT_CHECK_EXIT_CODE
4243
TIMEOUT 60
4344
ARGS "mode:=rosbag rosbag:=${DUMMY_BAG_PATH} run_rviz:=False run_foxglove:=False"
4445
)
4546

4647
add_graph_startup_test(single_cam_perceptor_dry_run
4748
launch/perceptor.launch.py
49+
DONT_CHECK_EXIT_CODE
4850
TIMEOUT 60
4951
ARGS "mode:=rosbag rosbag:=${DUMMY_BAG_PATH} run_rviz:=False run_foxglove:=False stereo_camera_configuration:=front_configuration"
5052
)

0 commit comments

Comments
 (0)