[Fix] support update score in find(V**)#233
Merged
jiashuy merged 2 commits intoNVIDIA-Merlin:masterfrom Sep 23, 2025
Merged
Conversation
Collaborator
Author
|
/blossom-ci |
1 similar comment
Collaborator
Author
|
/blossom-ci |
Member
|
/blossom-ci |
1 similar comment
Member
|
/blossom-ci |
Member
|
/blossom-ci |
2 similar comments
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
closed to restart CI |
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-233 |
rhdong
reviewed
Sep 20, 2025
include/merlin_hashtable.cuh
Outdated
| score_type* scores = nullptr, // (n) | ||
| cudaStream_t stream = 0, bool unique_key = true) const { | ||
| cudaStream_t stream = 0, bool unique_key = true, | ||
| bool update_score = false) { |
Member
There was a problem hiding this comment.
I recommend declaring a new find_and_update instead of reuse this find**
Collaborator
Author
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.