Skip to content

Commit 4e39468

Browse files
lint
Signed-off-by: Zhiyu Li <[email protected]>
1 parent f35ee08 commit 4e39468

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

nemo_automodel/components/distributed/fsdp2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,9 @@ def _try_flatten_submesh(submesh_dims: list, flattened_name: str) -> None:
259259
logger.debug(f"Skipping {flattened_name} flatten (dimensions are all size 1)")
260260

261261
# Create flattened submeshes for data parallelism combinations
262-
_try_flatten_submesh(dp_mesh_dim_names, "dp") # dp_replicate + dp_shard
262+
_try_flatten_submesh(dp_mesh_dim_names, "dp") # dp_replicate + dp_shard
263263
_try_flatten_submesh(dp_shard_cp_mesh_dim_names, "dp_shard_cp") # dp_shard + cp
264-
_try_flatten_submesh(dp_cp_mesh_dim_names, "dp_cp") # dp_replicate + dp_shard + cp
264+
_try_flatten_submesh(dp_cp_mesh_dim_names, "dp_cp") # dp_replicate + dp_shard + cp
265265

266266
return self.device_mesh
267267

nemo_automodel/components/distributed/parallelizer.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,7 @@ def parallelize(
158158
tp_mesh = device_mesh[tp_mesh_name]
159159

160160
# Determine the appropriate FSDP mesh dimensions (must be 1D or 2D)
161-
dp_mesh_dim_names = self._resolve_fsdp_mesh_dims(
162-
device_mesh, dp_replicate_mesh_name, dp_shard_cp_mesh_name
163-
)
161+
dp_mesh_dim_names = self._resolve_fsdp_mesh_dims(device_mesh, dp_replicate_mesh_name, dp_shard_cp_mesh_name)
164162
dp_mesh = device_mesh[dp_mesh_dim_names]
165163

166164
# Extract layers from the model for parallelization

0 commit comments

Comments
 (0)